Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CSS vars for max & current index #5

Open
GerkinDev opened this issue May 6, 2021 · 2 comments · May be fixed by #6
Open

Add CSS vars for max & current index #5

GerkinDev opened this issue May 6, 2021 · 2 comments · May be fixed by #6

Comments

@GerkinDev
Copy link

Hi,

I'd like to customize this component using CSS, for example by scaling the star depending on the index of the current item in the range. This could be done easily by binding CSS vars on the container with the total items, and CSS vars on each of the buttons.

Would you accept a PR about that ?
@fvilers
Copy link
Owner

fvilers commented Jun 15, 2021

Sorry for the late reply, I've been quite busy lately. Hi, I'd gladly accept a PR for this feature.

GerkinDev added a commit to KnodesCommunity/ngx-material-rating that referenced this issue Jun 16, 2021
@GerkinDev
feat: add css variables for rating-max, rating-value & rating-frac
6a45716 
Closes fvilers#5
@GerkinDev GerkinDev linked a pull request Jun 16, 2021 that will close this issue
Open
@GerkinDev
Copy link
Author

PR posted. I could do further work by allowing passing a ng-template to render whatever the user wants, instead of being forced to use stars.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@fvilers @GerkinDev