Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FvwmPager: pin new_desk events to monitor instance for per-monitor mode #296

Closed
ThomasAdam opened this issue Nov 29, 2020 · 1 comment · Fixed by #297
Closed

FvwmPager: pin new_desk events to monitor instance for per-monitor mode #296

ThomasAdam opened this issue Nov 29, 2020 · 1 comment · Fixed by #297
Assignees
@ThomasAdam
Labels
type:bug Something's broken!
Milestone
1.0.2

Comments

@ThomasAdam
Copy link
Member

ThomasAdam commented Nov 29, 2020 •
edited
Loading

When FvwmPager is clamped to a specific monitor, via:

DestroyModuleConfig FvwmPager:*
*FvwmPager: Monitor $$[monitor.current]
FvwmPager * *

... and DesktopConfiguration per-monitor is in use, switching to a new desk would result in all pagers operating on independent screens to switch to the new desk. This should only work for the monitor for which that pager should be switched, not all.
@issue-label-bot
Copy link

Issue-Label Bot is automatically applying the label enhancement to this issue, with a confidence of 0.60. Please mark this comment with 👍 or 👎 to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

@issue-label-bot issue-label-bot bot added the type:enhancement Augmenting an existing feature label Nov 29, 2020
@ThomasAdam ThomasAdam self-assigned this Nov 29, 2020
@ThomasAdam ThomasAdam added type:bug Something's broken! and removed type:enhancement Augmenting an existing feature labels Nov 29, 2020
@ThomasAdam ThomasAdam added this to the 1.0.2 milestone Nov 29, 2020
ThomasAdam added a commit that referenced this issue Nov 29, 2020
@ThomasAdam
FvwmPager: filter out new_desk events per-monitor
a75f798 
When FvwmPager is in per-monitor mode, filter out the new_desk event so
that it applies to that specific pager.  Prior to this, *all* FvwmPager
instances would have been asked to switch to a new desk which isn't
desirable.

Fixes #296
@ThomasAdam ThomasAdam mentioned this issue Nov 29, 2020
Merged
ThomasAdam added a commit that referenced this issue Nov 29, 2020
@ThomasAdam
FvwmPager: filter out new_desk events per-monitor
8a5214a 
When FvwmPager is in per-monitor mode, filter out the new_desk event so
that it applies to that specific pager.  Prior to this, *all* FvwmPager
instances would have been asked to switch to a new desk which isn't
desirable.

Fixes #296
@ThomasAdam ThomasAdam moved this to Done in FVWM3 Sep 18, 2022
@ThomasAdam ThomasAdam added this to FVWM3 Sep 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ThomasAdam ThomasAdam

Labels
type:bug Something's broken!
Projects
FVWM3
Status: Done
Milestone
1.0.2
Development

Successfully merging a pull request may close this issue.

FvwmPager: filter out new_desk events per-monitor fvwmorg/fvwm3
1 participant
@ThomasAdam