Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moving shaded windows across screens #473

Closed
lgsobalvarro opened this issue Apr 10, 2021 · 4 comments · Fixed by #474 or #479
Closed

Moving shaded windows across screens #473

lgsobalvarro opened this issue Apr 10, 2021 · 4 comments · Fixed by #474 or #479
Assignees
@ThomasAdam
Labels
type:bug Something's broken!
Milestone
1.0.3

Comments

@lgsobalvarro
Copy link
Contributor

  • Fvwm3 version (run: fvwm3 --version)
    1.0.3 (1.0.2-99-g3c32c16d)

  • Linux distribution or BSD name/version
    OpenSUSE Tumbleweed

  • Platform (run: uname -sp)
    Linux x86_64

Actual Behaviour

I moved a shaded window from Screen 1 (Main, edp) to Screen2 (hdmi-0-a), and then unshaded it. The window was lost.

Alt-tabbing placed it again where it was originally placed on Screen2

Steps to Reproduce

  1. Shade a window
  2. Move Shaded window from Screen 1, to Screen 2
  3. Unshade window.
@lgsobalvarro lgsobalvarro added the type:bug Something's broken! label Apr 10, 2021
@ThomasAdam
Copy link
Member

The steps reproducing this are more subtle:

  1. Set DesktopSize 3x3
  2. Set DesktopConfiguration per-monitor
  3. Make each monitor have a separate desktop to one another
  4. Move to the first screen, random page
  5. Open a window - shade it.
  6. Move it to the second monitor
  7. Unshade it.

Problem occurs.

@ThomasAdam ThomasAdam self-assigned this Apr 10, 2021
@ThomasAdam ThomasAdam added this to the 1.0.3 milestone Apr 10, 2021
@lgsobalvarro
Copy link
Contributor Author

Yes, you are right. I forgot to mention a couple of things. I'll clarify then:

  1. DesktopConfiguration is set as per-monitor
  2. DesktopSize is set to 2x8
  3. Only one desktop (0) is being used

Further testing has shown me that the issue presents itself when the page where the window is moved is different of 0,0.
When the window is unshaded it seems to move to 0,0, however the window does not look as expected.
Screenshot_20210410_133926

Shading and unshading again seems to fix the problem.

My config has not changed much since last time I shared with you.

Also: Moving a shaded window from Screen2 to Screen1 and unshading it do not cause this problem.

ThomasAdam added a commit that referenced this issue Apr 10, 2021
@ThomasAdam
absolute geometry: update screen
36bd27b 
Tell the client which screen it is on, prior to its geometry being
updated here.  Certain callers, when updating a window's geometry,
bypass some of the sanity checks, and the screen assignment gets
outdated.

Fixes #473
@ThomasAdam ThomasAdam mentioned this issue Apr 10, 2021
Merged
@ThomasAdam
Copy link
Member

Hi @lgsobalvarro

Thanks. Please can you try the ta/gh-473 branch -- I think the code there fixes this issue?

@lgsobalvarro
Copy link
Contributor Author

It works now. I can't reproduce this anymore after trying ta/gh-473

ThomasAdam added a commit that referenced this issue Apr 10, 2021
@ThomasAdam
absolute geometry: update screen
7262959 
Tell the client which screen it is on, prior to its geometry being
updated here.  Certain callers, when updating a window's geometry,
bypass some of the sanity checks, and the screen assignment gets
outdated.

Fixes #473
ThomasAdam added a commit that referenced this issue Apr 17, 2021
@ThomasAdam
absolute_geometry: clamp check to shaded windows
9a047db 
When updating a window's active monitor, the absolute geometry only
needs to be rechecked if the window is shaded, and at no other time.

This builds on a previous commit, and again fixes #473
@ThomasAdam ThomasAdam mentioned this issue Apr 17, 2021
Merged
ThomasAdam added a commit that referenced this issue Apr 17, 2021
@ThomasAdam
absolute_geometry: clamp check to shaded windows
d7a890b 
When updating a window's active monitor, the absolute geometry only
needs to be rechecked if the window is shaded, and at no other time.

This builds on a previous commit, and again fixes #473
@ThomasAdam ThomasAdam moved this to Done in FVWM3 Sep 18, 2022
@ThomasAdam ThomasAdam added this to FVWM3 Sep 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ThomasAdam ThomasAdam

Labels
type:bug Something's broken!
Projects
FVWM3
Status: Done
Milestone
1.0.3
2 participants
@ThomasAdam @lgsobalvarro