Windows from various pages are moved to page 0 0 on fvwm3 restart

[NsCDE]

• Fvwm3 version (run: fvwm3 --version)

fvwm3 1.0.5 (1.0.4-136-gad9356be)
with support for: ReadLine, XPM, PNG, SVG, Shape, XShm, SM, Bidi text, XRandR, XRender, XCursor, XFT, NLS

It is from 6. 9. 2022, testing of #655 on @ThomasAdam request.

• Linux distribution or BSD name/version

Debian 11

• Platform (run: uname -sp)

Linux x86_64

Expected Behaviour

Windows put back on their pages and exact places after restart

Actual Behaviour

All windows (from pages 0 1, 1 0, 1 1 (it is 2x2 matrix)) are moved on the 0 0 page.

Steps to Reproduce

With NsCDE 2.2 default 4 desks, 2x2 pages configuration.

Extra Information

I vaguely remember this has been the problem 1-2 years ago, but I cannot find particular issue anymore, so I opened this one.

[ThomasAdam]

@NsCDE,

I've never been able to reproduce this consistently, and haven't seen this occur for some time.

One thing that would help me is if you can tell me:

1. Which application(s) are moved from where they were -- are they always the same applications each time? I tend to test with xterm, for example.
2. You will find under FVWM_USERDIR (which I think defaults to $HOME/.NsCDE for NsCDE?), a file which starts .fs-restart- as its filename. Can you attach that file to this bug report, and tell me from that file, which applications have been moved upon restart?
3. Can you also attach a copy of the fvwm3-debug.log file? I believe you enable that by default in NsCDE? If not, please do, so I can marry up the information here, with the .fs-restart file.

The file from point 2., above, holds the associated state about each application so that fvwm can -- upon recapture of the window -- apply the appropriate state to it, such as which desk it's on, the page, etc.

[NsCDE]

Hi @ThomasAdam

All apps are moved: xterm, gtk, qt based ... no matter what. The size and position remains correct, but page is changed.

PFA screenshots before restart and after restart and fvwm.log (which is on by default as you know), but it looks like most of the things are in dot_xsession-errors (also in logs.zip). I cannot find .fs-restart file IN any dir, is there a way to force it to be preserved after restart?

logs.zip

[NsCDE]

@ThomasAdam

You forgot to tell me that .fs-restart* long time existance is configurable only in fvwm/fvwm3.c :-)

I have commented out unlink from there, so here is the file while restarting with windows on various pages.
dot_fs-restart.txt

[ThomasAdam]

@NsCDE

I've had fvwm3 in a reboot loop for the last 30 minutes, selecting random pages and adding windows to them. I did not observe fvwm3 losing windows, or moving them away from the positions they were in before fvwm restarted.

Are you able to reproduce this using just the default fvwm config?

You could perhaps try the ta/gh-694 branch to see if it helps.

[NsCDE]

Hi @ThomasAdam

I tried ta/gh-694, it doesn't fix this. Meanwhile, have discovered that this happens only in "shared" DesktopConfiguration mode, not in global or per-monitor. I saw this while testing something in one-monitor mode (which of course doesn't make sense for shared and per-monitor), but also in dual monitor mode now.

[ThomasAdam]

Meanwhile, have discovered that this happens only in "shared" DesktopConfiguration mode

Right. This makes sense now. I'll have a fix for this in a bit.

[ThomasAdam]

Hi @NsCDE

Not sure if I've completely got all the edge cases, but try looking at ta/gh-694 again.

[ThomasAdam]

Scratch that -- I've just found another bug.

[NsCDE]

Yes, I see. Everything is global here.

[ThomasAdam]

Hi @NsCDE

OK -- I've pushed a fix on top of what I had. Please test this.

I am not expecting this to be perfect, as I am sure there's plenty of corner-cases.

[NsCDE]

You did it Thomas.

Works as expected. Tried with dual and single monitor, with apps on pages and on another desks. It seems like Restart is now preserving everything in shared DesktopConfiguration mode.