ConfigWinPacket: no longer send monitor_name #1074
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because of the padding and the alignment in the CongfigWinPacket, trying to fit a monitor name >8 characters would truncate. Instead, if modules need to look up the monitor from the window packet, do so via the monitor_id which was already being sent down. Currently, only FvwmIconMan is affected. Noticed by jns and somiaj on IRC.
ThomasAdam
force-pushed
the
ta/goodbye-monitor-name
branch
from
63f47ec to
8e01c3d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because of the padding and the alignment in the CongfigWinPacket, trying
to fit a monitor name >8 characters would truncate.
Instead, if modules need to look up the monitor from the window packet,
do so via the monitor_id which was already being sent down.
Currently, only FvwmIconMan is affected.
Noticed by jns and somiaj on IRC.