Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FvwmPager: fix geometry string values when using @MONITORNAME #309

Merged
merged 1 commit into from
Dec 3, 2020

Conversation

ThomasAdam
Copy link
Member

@ThomasAdam ThomasAdam commented Dec 2, 2020

When FvwmPager parses a geometry string with a monitor name embedded in
it, such as:

    *FvwmPager: Geometry 100x90-0+0@MONITORNAME

FvwmPager would not take into account MONITORNAME's dimensions, instead
defaulting to the current monitor.

This results from an incorrect use of global screen, vs specific screen.
Geometry strings are treated as the global screen, so FvwmPager needs to
use those values when calculating where to place its window.

When FvwmPager parses a geometry string with a monitor name embedded in
it, such as:

    *FvwmPager: Geometry 100x90-0+0@MONITORNAME

FvwmPager would not take into account MONITORNAME's dimensions, instead
defaulting to the current monitor.

This results from an incorrect use of global screen, vs specific screen.
Geometry strings are treated as the global screen, so FvwmPager needs to
use those values when calculating where to place its window.

Fixes #310
@ThomasAdam ThomasAdam force-pushed the ta/fvwmpager-geom-fix branch from e9da58d to 3c42563 Compare December 3, 2020 18:56
@ThomasAdam ThomasAdam marked this pull request as ready for review December 3, 2020 18:56
@ThomasAdam ThomasAdam changed the title FvwmPager: fix offset geom calcs FvwmPager: fix geometry string values when using @MONITORNAME Dec 3, 2020
@ThomasAdam ThomasAdam merged commit 2f0d37a into master Dec 3, 2020
@ThomasAdam ThomasAdam deleted the ta/fvwmpager-geom-fix branch December 3, 2020 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant