-
-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure a default colorset is always configured. #740
Conversation
Set a default colorset for active and inactive windows to ensure it is always configured if a user doesn't configure it themselves.
1ff99eb
to
d373b39
Compare
I wonder if this is a breaking change? In the sense that now, a user is going to need to set both |
Let me see if I understand (I didn't test this), if I think it should probably be by default that 'Colorset X' changes both the title bar and the border, unless the user explicitly sets the |
Yeah... I think you've understood my ramblings. ;) If you're able to test your idea, please do. If not, I'll see if I can do so over the weekend. |
# Changelog ## [1.0.6a](https://github.com/fvwmorg/fvwm3/tree/1.0.6a) (2023-01-16) ## What's Changed ### Other Changes * dist: doc: include all doc sources by @ThomasAdam in fvwmorg/fvwm3#806 **Full Changelog**: fvwmorg/fvwm3@1.0.6...1.0.6a ## [1.0.6](https://github.com/fvwmorg/fvwm3/tree/1.0.6) (2023-01-14) ## What's Changed ### Breaking Changes * remove fvwm-config by @ThomasAdam in fvwmorg/fvwm3#731 * ta/alloca by @ThomasAdam in fvwmorg/fvwm3#722 * deprecate color commands by @ThomasAdam in fvwmorg/fvwm3#738 * Ensure a default colorset is always configured. by @somiaj in fvwmorg/fvwm3#740 * commands: remove DefaultColors & DefaultColorset by @ThomasAdam in fvwmorg/fvwm3#749 * MenuStyle: Remove Depreciated options and non colorset by @somiaj in fvwmorg/fvwm3#757 ### Enhancements * decor: allow window borders separate colours by @ThomasAdam in fvwmorg/fvwm3#730 * Update Move shuffle logic to jump to next monitor by @somiaj in fvwmorg/fvwm3#742 * conditional: screen: simplify logic by @ThomasAdam in fvwmorg/fvwm3#746 * Allow SidePic in default-config. by @somiaj in fvwmorg/fvwm3#762 * Move shuffle, ensure window inside working area. by @somiaj in fvwmorg/fvwm3#767 * Translucent Menus by @somiaj in fvwmorg/fvwm3#760 * Updates to FvwmPager scaling math to improve visual aspects due to rounding errors. by @somiaj in fvwmorg/fvwm3#790 ### Other Changes * doc: don't install fvwm3_manpage_source by @ThomasAdam in fvwmorg/fvwm3#712 * Rename .stalonetrayrc to stalonetrayrc by @wfp5p in fvwmorg/fvwm3#713 * Fix background resetting in default-config by @somiaj in fvwmorg/fvwm3#714 * desk_add: fix window counting by @ThomasAdam in fvwmorg/fvwm3#716 * remove unused variable by @omar-polo in fvwmorg/fvwm3#718 * two clock_t and time_t casts for portability by @omar-polo in fvwmorg/fvwm3#719 * changing sprintf -> snprintf & co by @omar-polo in fvwmorg/fvwm3#720 * DesktopConfiguration: send status_send() by @ThomasAdam in fvwmorg/fvwm3#724 * FvwmScript.c: fix wrong size of TabCom array by @slazav in fvwmorg/fvwm3#725 * gotodesk: simplify logic for shared/global by @ThomasAdam in fvwmorg/fvwm3#727 * Add a multicolor border example to default-config by @somiaj in fvwmorg/fvwm3#732 * Some pedantic clean up of whitespace and add missing translation strings. by @somiaj in fvwmorg/fvwm3#733 * Tweak HilightBorderColorset by @lgsobalvarro in fvwmorg/fvwm3#737 * docs: remove obsolete GNOME references by @ThomasAdam in fvwmorg/fvwm3#739 * MWMBorder: fix calculation by @ThomasAdam in fvwmorg/fvwm3#743 * Don't set border colorsets by default. by @somiaj in fvwmorg/fvwm3#747 * style: silence warning for unconsumed string by @ThomasAdam in fvwmorg/fvwm3#745 * Add split manpages to default-config. by @somiaj in fvwmorg/fvwm3#750 * FvwnIconMan use font as fallback for tips font. by @somiaj in fvwmorg/fvwm3#751 * FvwmIconMan: Don't chop window display string by @somiaj in fvwmorg/fvwm3#752 * fvwm-config: remove .in file by @ThomasAdam in fvwmorg/fvwm3#758 * FvwmPager make mini windows always round down. by @somiaj in fvwmorg/fvwm3#756 * Clean up some build warnings by @somiaj in fvwmorg/fvwm3#759 * Move shuffle modifications. by @somiaj in fvwmorg/fvwm3#764 * borders: treat 0 pixels as 1 pixel border by @ThomasAdam in fvwmorg/fvwm3#765 * AddWindow: don't crash reparenting by @ThomasAdam in fvwmorg/fvwm3#786 * ModuleSynchronous: don't segfault on free() by @ThomasAdam in fvwmorg/fvwm3#787 * FvwmIconMan: fix segfault in initialisation by @ThomasAdam in fvwmorg/fvwm3#800 * randr: quit when no screens found & not active by @ThomasAdam in fvwmorg/fvwm3#801 ## New Contributors * @wfp5p made their first contribution in fvwmorg/fvwm3#713 **Full Changelog**: fvwmorg/fvwm3@1.0.5...1.0.6 ## [1.0.5](https://github.com/fvwmorg/fvwm3/tree/1.0.5) (2022-09-28)
Set a default colorset for active and inactive windows to ensure it is always configured if a user doesn't configure it themselves.
With removing the old color methods, no default colorset is being set (test using a blank config
fvwm3 -c /dev/null
). This ensures that a default colorset both both active and inactive windows is always configured.