Wiring the views with the server. r=samgiles #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| speechController: Symbol('speechController'), | ||
| server: Symbol('speechController'), |
There was a problem hiding this comment.
Description of the symbol should probably be server.
There was a problem hiding this comment.
Ah yes, I'll fix it.
|
|
||
| // Not all browsers have localStorage supported or activated. | ||
| this[p.storage] = storage || { | ||
| getItem: () => null, |
There was a problem hiding this comment.
nit: indentation? Looks off here.
There was a problem hiding this comment.
grrrr, it looks good to my IDE because the opening braces counts as an indentation level. I agree this looks weird.
|
I think that's it! We can revisit the push notifications when we set them up properly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.