Fixed compatibility with composer 2.1 #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hej @SamMousa, shouldn't we check, whether version_compare(Composer::RUNTIME_API_VERSION, '2.0.0', '>=')Or is there a reason to explicitly check for |
dsturm
added a commit
to zirkeldesign/foxy
that referenced
this pull request
Jun 14, 2021
Use php native `version_compare()` to fix bug in current composer `2.1.3`
|
@SamMousa It is preferable to use |
|
I used strict comparison because that's what was done in original code. I'm fine updating it to use version compare |
|
Yes, please, you might as well improve the code immediately :-) |
Use `version_compare` instead of string comparison
|
@francoispluchino, the PR is done but CI is broken. |
|
Bump |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #37