Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix anchor tags in frontmatter template #240

Merged
merged 2 commits into from
Aug 10, 2023
Merged

fix: Fix anchor tags in frontmatter template #240

merged 2 commits into from
Aug 10, 2023

Conversation

rodrigc
Copy link
Contributor

@rodrigc rodrigc commented Jun 11, 2023

This fix is already in the markdown template if you look here: https://github.com/fybrik/crdoc/blob/main/templates/markdown.tmpl#L65

This problem was discovered in https://github.com/grafana-operator/grafana-operator

Fixes: #241

Signed-off-by: Craig Rodrigues <rodrigc@crodrigues.org>
NissesSenap pushed a commit to grafana/grafana-operator that referenced this pull request Jun 13, 2023
* fix: Add local hugo templates

Incorporate pending fixes to upstream template:

* fybrik/crdoc#239
* fybrik/crdoc#240

* fix(doc): Fix broken links
Copy link
Contributor

@roytman roytman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @rodrigc , thanks for your PR

@roytman roytman merged commit a8fedb1 into fybrik:main Aug 10, 2023
6 checks passed
@rodrigc rodrigc deleted the fix-frontmatter-template branch August 16, 2023 22:25
NissesSenap pushed a commit to grafana/grafana-operator that referenced this pull request Aug 18, 2023
* fybrik/crdoc#239
* fybrik/crdoc#240

Signed-off-by: Craig Rodrigues <rodrigc@crodrigues.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

frontmatter template has broken links
2 participants