Skip to content
This repository has been archived by the owner on Dec 11, 2020. It is now read-only.

Improve german first names #361

Closed
mikehaertl opened this issue Jul 1, 2014 · 11 comments
Closed

Improve german first names #361

mikehaertl opened this issue Jul 1, 2014 · 11 comments

Comments

@mikehaertl
Copy link
Contributor

As a native I have to say, that the german first names don't look very german to me :).

Here's a list of the most frequently used first names:

@mikehaertl
Copy link
Contributor Author

@fzaninotto
Copy link
Owner

Could you submit a patch with a link to the references your mentioned?

mikehaertl added a commit to mikehaertl/Faker that referenced this issue Jul 2, 2014
@mikehaertl
Copy link
Contributor Author

Done. If done right, we'd actually also need a probability for each name. For example "Peter" is used 220599 times, whereas "Fatih" is only used 237 times.

Alternatively we could focus on the 500 most common names (instead of 1000 as it is right now).

@fzaninotto
Copy link
Owner

Fixed by #362

@mikehaertl
Copy link
Contributor Author

@fzaninotto What do you think about my suggestion above? I think, we get better results if we limit to the 500 most frequent names. The names 501-1000 contain too many very seldom names.

@fzaninotto
Copy link
Owner

Sounds fair.

mschoebel referenced this issue in joke2k/faker Sep 22, 2015
@Findus23
Copy link
Contributor

I known I'm a bit late, but would it be possible to improve the last names too?
I can't really believe that these are the most common last names. Especially names like auch Schlauchin don't make sense.
@mikehaertl Would it be possible to parse the names from https://de.wiktionary.org/wiki/Verzeichnis:Deutsch/Liste_der_h%C3%A4ufigsten_Nachnamen_Deutschlands ?
And while we're on it, is it possible to also update the Austrian Names from https://de.wiktionary.org/wiki/Verzeichnis:Deutsch/Liste_der_h%C3%A4ufigsten_Nachnamen_%C3%96sterreichs (or at least copy them from Germany)

@mikehaertl
Copy link
Contributor Author

@Findus23 It was mainly lack of time - and that I didn't need faker anymore so far. So feel free to send any updates you like. Also consider to update the first names like I've mentioned above. Most of them are not really sounding very german (yes, we have "multikulti" ;) - but still I think the "classical" german names are most common).

@Findus23
Copy link
Contributor

I'll see if I am able to update them.
Do you still have the script to parse the list and create the array?

@mikehaertl
Copy link
Contributor Author

No, sorry. I think I've just copy & pasted this into Vim and then used some regex to extract the names.

@Findus23
Copy link
Contributor

I have made the pull requests #825 and #826.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants