Add the option to generate HTML fragments and the body of an HTML doc… #1159

rudkjobing · 2017-03-11T20:05:33Z

Implement feature requested here: #971 (comment)

…ument.

rudkjobing · 2017-03-11T21:22:20Z

@fzaninotto Hmm is master broken? Tests wont run for me after I merged master into my fork.

Testing started at 10:18 PM ...
<?xml version="1.0" encoding="UTF-8"?><contacts>
PHP Notice:  Undefined offset: -32 in C:\SLFaker\src\Faker\Provider\Base.php on line 193
PHP Notice:  Undefined index:  in C:\SLFaker\src\Faker\Provider\Base.php on line 193
PHP Notice:  Undefined offset: -229 in C:\SLFaker\src\Faker\Provider\Base.php on line 193
PHP Notice:  Undefined index:  in C:\SLFaker\src\Faker\Provider\Base.php on line 193
PHP Fatal error:  Uncaught Exception: domainWord failed with the selected locale. Try a different locale or activate the "intl" PHP extension. in C:\SLFaker\src\Faker\Provider\Internet.php:138
Stack trace:
#0 C:\SLFaker\src\Faker\Provider\Internet.php(124): Faker\Provider\Internet->domainWord()
#1 [internal function]: Faker\Provider\Internet->domainName()
#2 C:\SLFaker\src\Faker\Generator.php(207): call_user_func_array(Array, Array)
#3 C:\SLFaker\src\Faker\Generator.php(241): Faker\Generator->format('domainName')
#4 [internal function]: Faker\Generator->callFormatWithMatches(Array)
#5 C:\SLFaker\src\Faker\Generator.php(236): preg_replace_callback('/\\{\\{\\s?(\\w+)\\s...', Array, '{{userName}}@{{...')
#6 C:\SLFaker\src\Faker\Provider\Internet.php(40): Faker\Generator->parse('{{userName}}@{{...')
#7 [internal function]: Faker\Provider\Internet->email()
#8 C:\SLFaker\src\Faker\Generator.php(207): call_user_func_array(Array, Array)
#9 C:\SLFaker\src\Faker\Generator.php(249): Faker\Generator->format('email')
#10 C:\SLFaker\test\te in C:\SLFaker\src\Faker\Provider\Internet.php on line 138
  <contact firstName="Arely" lastName="Champlin" email="
Notice: Undefined offset: -32 in C:\SLFaker\src\Faker\Provider\Base.php on line 193

Notice: Undefined index:  in C:\SLFaker\src\Faker\Provider\Base.php on line 193

Notice: Undefined offset: -229 in C:\SLFaker\src\Faker\Provider\Base.php on line 193

Notice: Undefined index:  in C:\SLFaker\src\Faker\Provider\Base.php on line 193

Fatal error: Uncaught Exception: domainWord failed with the selected locale. Try a different locale or activate the "intl" PHP extension. in C:\SLFaker\src\Faker\Provider\Internet.php:138
Stack trace:
#0 C:\SLFaker\src\Faker\Provider\Internet.php(124): Faker\Provider\Internet->domainWord()
#1 [internal function]: Faker\Provider\Internet->domainName()
#2 C:\SLFaker\src\Faker\Generator.php(207): call_user_func_array(Array, Array)
#3 C:\SLFaker\src\Faker\Generator.php(241): Faker\Generator->format('domainName')
#4 [internal function]: Faker\Generator->callFormatWithMatches(Array)
#5 C:\SLFaker\src\Faker\Generator.php(236): preg_replace_callback('/\\{\\{\\s?(\\w+)\\s...', Array, '{{userName}}@{{...')
#6 C:\SLFaker\src\Faker\Provider\Internet.php(40): Faker\Generator->parse('{{userName}}@{{...')
#7 [internal function]: Faker\Provider\Internet->email()
#8 C:\SLFaker\src\Faker\Generator.php(207): call_user_func_array(Array, Array)
#9 C:\SLFaker\src\Faker\Generator.php(249): Faker\Generator->format('email')
#10 C:\SLFaker\test\te in C:\SLFaker\src\Faker\Provider\Internet.php on line 138

Process finished with exit code 255

Zhythero · 2017-06-15T07:06:01Z

Sorry to be that guy, but any update on this?

WillGibson · 2017-06-19T16:50:39Z

test/Faker/Provider/HtmlLoremTest.php

+        $faker = new Generator();
+        $faker->addProvider(new HtmlLorem($faker));
+        $node = $faker->randomBody(5, 5);
+        echo $node;


I don't think you want the echo $node; line?

WillGibson · 2017-06-19T16:51:35Z

test/Faker/Provider/HtmlLoremTest.php

-        $node = $faker->randomHtml(6, 10);
+        $node = $faker->randomHtml(5, 5);
+        $dom = new \DOMDocument();
+        $error = $dom->loadHTML($node);


I think $isValidHTML would make more sense than $error as a variable name here and below.

WillGibson · 2017-06-19T16:52:42Z

Are, I was about to start making a a very similar PR. If you want any help getting this through the pip @Zhastreaus , give me a shout.

Zhythero · 2017-06-20T01:01:16Z

@WillGibson nope this is not my PR, I think it's @rudkjobing 's

WillGibson · 2017-06-20T07:28:24Z

@rudkjobing I'm going to fork from your fork and see if I can get the builds passing as I'd like to use this feature.

rudkjobing · 2017-06-20T07:44:04Z

I must be blind Fatal error: Call to a member function randomNumber() on a non-object in /home/travis/build/fzaninotto/Faker/src/Faker/Provider/HtmlLorem.php on line 153

WillGibson · 2017-06-20T10:00:05Z

test/Faker/Provider/HtmlLoremTest.php

@@ -20,10 +20,27 @@ public function testProvider()
    public function testRandomHtmlReturnsValidHTMLString(){
        $faker = new Generator();
        $faker->addProvider(new HtmlLorem($faker));
-        $node = $faker->randomHtml(6, 10);
+        $node = $faker->randomHtml(5, 5);
        $dom = new \DOMDocument();
        $error = $dom->loadHTML($node);


Maybe $isValidHtml instead of $error here too?

WillGibson · 2017-06-20T10:04:55Z

Looking good now @rudkjobing. Can't see any build info here now. Are they passing now you fixed the fatal error?

WillGibson · 2017-06-20T11:27:44Z

@rudkjobing I have a passing build here https://travis-ci.org/BiffBangPow/Faker/jobs/244895238. I'll try to submit a PR to your branch your with the fix.

rudkjobing · 2017-06-20T11:28:27Z

Awesome, thanks!

WillGibson · 2017-06-20T11:40:07Z

rudkjobing#1

Fix indenting to make builds pass

rudkjobing · 2017-06-20T11:44:56Z

Travis doesn't seem to run automatically?

WillGibson · 2017-06-20T11:46:40Z

It should run automatically because this is a PR I think, but you might need to log into Travis and add you repo/branch maybe?

rudkjobing · 2017-06-20T12:04:52Z

I havn't had issues with travis before. Don't really know what the problem is.

WillGibson · 2017-06-20T13:14:15Z

Me neither, and I can't play with your Travis builds directly I guess. It should build automatically under fzaninotto/Faker as it's a PR, at least that what I thought. @fzaninotto Can you help here? I had a passing build here (https://travis-ci.org/BiffBangPow/Faker/builds/244900976) if that's any use.

WillGibson · 2017-06-20T13:30:57Z

src/Faker/Provider/HtmlLorem.php

+     *
+     * @return string
+     */
+    public function randomBody($maxDepth = 4, $maxWidth = 4)


Now that I'm using this in my actual developing code, I think this would be better called randomHTMLBody.

rudkjobing · 2017-06-20T14:08:23Z

Going to open a new pull request, to see if that helps.

WillGibson · 2017-06-20T14:11:21Z

Hi @rudkjobing

Fingers crossed re the new PR.

Please forgive my amatuerish approach to commenting on PRs in GitHub, I'm just getting used to how it all works (we use BitBucket here at work so the UI is different) and trying to get a bit more involved, help out with open source stuff.

There's a couple more comments in there from me that I would like addressed unless you disagree with them, then I'm totally going to approve this PR which has saved me doing the same thing over here.

https://github.com/fzaninotto/Faker/pull/1159/files#diff-ecbf0f117b3c8b63635081589370cce6R91

https://github.com/fzaninotto/Faker/pull/1159/files#diff-b3f77ef5414bc4a1b3641d7567ae3998R25

Will

rudkjobing · 2017-06-20T14:15:18Z

Hi Will.

Don't worry! I did change the code based on your change requests. I made a new PR here: #1237 but travis still ignores it.

Add the option to generate HTML fragments and the body of an HTML doc…

2bf64de

…ument.

WillGibson reviewed Jun 19, 2017

View reviewed changes

rudkjobing and others added 2 commits June 20, 2017 09:54

-Changes from code review.

15295e6

Merge branch 'master' into master

25d709c

WillGibson reviewed Jun 20, 2017

View reviewed changes

Fix indenting

cacd47b

Merge pull request #1 from BiffBangPow/master

a1b8b76

Fix indenting to make builds pass

rudkjobing changed the base branch from master to country_names June 20, 2017 12:00

rudkjobing changed the base branch from country_names to master June 20, 2017 12:00

rudkjobing closed this Jun 20, 2017

rudkjobing reopened this Jun 20, 2017

rudkjobing closed this Jun 20, 2017

rudkjobing reopened this Jun 20, 2017

WillGibson reviewed Jun 20, 2017

View reviewed changes

-Rename randomBody method to randomHTMLBody

d549894

Merge remote-tracking branch 'origin/master'

f4726b2

rudkjobing closed this Jun 20, 2017

WillGibson mentioned this pull request Jun 21, 2017

Fake html body #1237

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add the option to generate HTML fragments and the body of an HTML doc… #1159

Add the option to generate HTML fragments and the body of an HTML doc… #1159

rudkjobing commented Mar 11, 2017

rudkjobing commented Mar 11, 2017 •

edited

Loading

Zhythero commented Jun 15, 2017

WillGibson Jun 19, 2017

WillGibson Jun 19, 2017

WillGibson commented Jun 19, 2017

Zhythero commented Jun 20, 2017

WillGibson commented Jun 20, 2017

rudkjobing commented Jun 20, 2017

WillGibson Jun 20, 2017

WillGibson commented Jun 20, 2017

WillGibson commented Jun 20, 2017

rudkjobing commented Jun 20, 2017

WillGibson commented Jun 20, 2017

rudkjobing commented Jun 20, 2017

WillGibson commented Jun 20, 2017

rudkjobing commented Jun 20, 2017

WillGibson commented Jun 20, 2017

WillGibson Jun 20, 2017

rudkjobing commented Jun 20, 2017

WillGibson commented Jun 20, 2017

rudkjobing commented Jun 20, 2017 •

edited

Loading

Add the option to generate HTML fragments and the body of an HTML doc… #1159

Add the option to generate HTML fragments and the body of an HTML doc… #1159

Conversation

rudkjobing commented Mar 11, 2017

rudkjobing commented Mar 11, 2017 • edited Loading

Zhythero commented Jun 15, 2017

WillGibson Jun 19, 2017

Choose a reason for hiding this comment

WillGibson Jun 19, 2017

Choose a reason for hiding this comment

WillGibson commented Jun 19, 2017

Zhythero commented Jun 20, 2017

WillGibson commented Jun 20, 2017

rudkjobing commented Jun 20, 2017

WillGibson Jun 20, 2017

Choose a reason for hiding this comment

WillGibson commented Jun 20, 2017

WillGibson commented Jun 20, 2017

rudkjobing commented Jun 20, 2017

WillGibson commented Jun 20, 2017

rudkjobing commented Jun 20, 2017

WillGibson commented Jun 20, 2017

rudkjobing commented Jun 20, 2017

WillGibson commented Jun 20, 2017

WillGibson Jun 20, 2017

Choose a reason for hiding this comment

rudkjobing commented Jun 20, 2017

WillGibson commented Jun 20, 2017

rudkjobing commented Jun 20, 2017 • edited Loading

rudkjobing commented Mar 11, 2017 •

edited

Loading

rudkjobing commented Jun 20, 2017 •

edited

Loading