This repository has been archived by the owner on Dec 11, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Fake html body #1237
Closed
Closed
Fake html body #1237
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
2bf64de
Add the option to generate HTML fragments and the body of an HTML doc…
15295e6
-Changes from code review.
25d709c
Merge branch 'master' into master
rudkjobing cacd47b
Fix indenting
a1b8b76
Merge pull request #1 from BiffBangPow/master
rudkjobing d549894
-Rename randomBody method to randomHTMLBody
f4726b2
Merge remote-tracking branch 'origin/master'
6e7ff7a
Add the option to generate HTML fragments and the body of an HTML doc…
09c8c42
-Fix conflicts
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -66,6 +66,36 @@ public function randomHtml($maxDepth = 4, $maxWidth = 4) | |
return $document->saveHTML(); | ||
} | ||
|
||
/** | ||
* @param int $maxDepth | ||
* @param int $maxWidth | ||
* | ||
* @return string | ||
*/ | ||
public function randomHTMLBody($maxDepth = 4, $maxWidth = 4) | ||
{ | ||
$document = new \DOMDocument(); | ||
|
||
$body = $document->createElement("body"); | ||
$this->addRandomSubTree($body, $maxDepth, $maxWidth); | ||
$document->appendChild($body); | ||
return $document->saveHTML(); | ||
} | ||
|
||
/** | ||
* @param int $maxDepth | ||
* @param int $maxWidth | ||
* | ||
* @return string | ||
*/ | ||
public function randomBodyFragments($maxDepth = 4, $maxWidth = 4) | ||
{ | ||
$html = $this->randomHTMLBody($maxDepth, $maxWidth); | ||
$matches = array(); | ||
preg_match("/\<body\>(.*)<\/body\>/", $html, $matches); | ||
return $matches[1]; | ||
} | ||
|
||
private function addRandomSubTree(\DOMElement $root, $maxDepth, $maxWidth) | ||
{ | ||
$maxDepth--; | ||
|
@@ -129,7 +159,8 @@ private function addRandomAttribute(\DOMElement $node) | |
$node->setAttribute("class", $this->generator->word); | ||
break; | ||
case 2: | ||
$node->setAttribute("id", (string)$this->idGenerator->randomNumber(5)); | ||
$randomNumber = $this->generator->randomNumber(5); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This line want another space, or it the builds will fail on the code sniffing stage. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It was tabs not spaces. Done in my fork. |
||
$node->setAttribute("id", (string)$randomNumber); | ||
break; | ||
} | ||
} | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -20,10 +20,27 @@ public function testProvider() | |
public function testRandomHtmlReturnsValidHTMLString(){ | ||
$faker = new Generator(); | ||
$faker->addProvider(new HtmlLorem($faker)); | ||
$node = $faker->randomHtml(6, 10); | ||
$node = $faker->randomHtml(5, 5); | ||
$dom = new \DOMDocument(); | ||
$error = $dom->loadHTML($node); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Done in my fork. |
||
$this->assertTrue($error); | ||
} | ||
|
||
public function testRandomBodyReturnsValidHTMLString(){ | ||
$faker = new Generator(); | ||
$faker->addProvider(new HtmlLorem($faker)); | ||
$node = $faker->randomHTMLBody(5, 5); | ||
$dom = new \DOMDocument(); | ||
$isValidHtml = $dom->loadHTML($node); | ||
$this->assertTrue($isValidHtml); | ||
} | ||
|
||
public function testRandomBodyFragment(){ | ||
$faker = new Generator(); | ||
$faker->addProvider(new HtmlLorem($faker)); | ||
$fragment = $faker->randomBodyFragments(5, 5); | ||
$this->assertStringStartsWith("<", $fragment); | ||
$this->assertStringEndsWith(">", $fragment); | ||
} | ||
|
||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could this be
randomHTMLFragments
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have done this in my fork