Add the option to generate HTML fragments and the body of an HTML document #1238
Conversation
|
@fzaninotto I appreciate that the commit history has gotten itself a bit loose in here. I'll have a go at rebasing this on your master maybe to see if I can straighten that up. |
WillGibson
force-pushed
the
fake_html_body
branch
2 times, most recently
from
80d955e
to
e983da8
Compare
WillGibson
force-pushed
the
fake_html_body
branch
from
e983da8
to
d6f22cf
Compare
| */ | ||
| private function addUniqueIdAttribute(\DOMElement $node) | ||
| { | ||
| for ($x = 1; $x <= 10000; $x++) { |
There was a problem hiding this comment.
Better use a while than a for that you'll break. Oh, and you're free to use recursion by the way.
|
I just stumbled across this PR and it's so old I can't even remember anything about it's context, so I'm closing it. |
|
Hey @WillGibson, any chance of reviving this? |
|
I'm afraid I don't have time to look at it and, if I'm being honest, aside from it being do long ago I can't remember it, I'm not using this library for anything at the moment, or even PHP just now. |
Takes work done by @rudkjobing to allow for generating HTML without it needing to be a complete HTML document.
Then issue of it sometimes creating HTML with no human readable text content was addressed and builds got passing again on the various versions of PHP.