Skip to content
This repository has been archived by the owner on Dec 11, 2020. It is now read-only.

[CLOSED] Fix CURL status code in ImageTest.php #1289

Closed
wants to merge 22 commits into from
Closed

[CLOSED] Fix CURL status code in ImageTest.php #1289

wants to merge 22 commits into from

Conversation

Sanfra1407
Copy link
Contributor

@Sanfra1407 Sanfra1407 commented Sep 4, 2017

Edit

Moved to #1290

Description

http://lorempixel.com/ is being skipped because it responds with 301 instead of 200

Code

$url = "http://lorempixel.com/"; // line 48

if ($httpCode < 200 | $httpCode > 300) {   // line 57
    $this->markTestSkipped("LoremPixel is offline, skipping image download");
}

File

test/Faker/Provider/ImageTest.php

@fzaninotto
Copy link
Owner

Bad list of commits, the content of the PR doesn't match your description.

@Sanfra1407 Sanfra1407 closed this Sep 4, 2017
@Sanfra1407 Sanfra1407 deleted the test-image branch September 4, 2017 09:39
@Sanfra1407 Sanfra1407 restored the test-image branch September 4, 2017 09:39
@Sanfra1407 Sanfra1407 deleted the test-image branch September 4, 2017 09:47
@Sanfra1407 Sanfra1407 changed the title Fix CURL status code in ImageTest.php [CLOSED] Fix CURL status code in ImageTest.php Sep 4, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants