Added es_VE provider (Venezuela) #398
Conversation
| '{{lastName}} de {{lastName}}' | ||
| ); | ||
|
|
||
| protected static $catchPhraseWords = array( |
There was a problem hiding this comment.
This one is not localized, no need to override it.
There was a problem hiding this comment.
I don't understand this note. Actually it's localized, the $companyPrefix and $companySuffix were changed and one format was removed.
There was a problem hiding this comment.
The words are in English, it's supposed to be a Venezuelian provider, its data should be in es_VE.
There was a problem hiding this comment.
If you mean the formats the words "Y" and "de" are spanish prepositions. The formats are also like others es_* providers and you can check some venezuelan formats at this list of companies http://declaraciones.seniat.gob.ve/portal/page/portal/MANEJADOR_CONTENIDO_SENIAT/05MENU_HORIZONTAL/5-2.html
The next PR won't have the methods catchPhrase and bs.
|
Still missing source for datasets. |
|
If you mean about the format for person provider, I added the link at the first method as example. |
|
All right. Can you please copy the link before each dataset? It's a good practice that I ask to all contributors. |
|
Would you mind squashing the commits to avoid the two merge commits? |
|
Hello, Did you forget about this PR? |
Added es_VE provider (Venezuela)
|
Yes I did. Sorry for the delay and thanks for your contribution! |
New provider