-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Conversation
}; | ||
case 'integer': | ||
return function() { | ||
return mt_rand(0, intval('2147483647')); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why not use `randomNumber()?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can change those, I took those directly from here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The randomFloat
formatter and others were probably added after the Propel ORM populator. But they are faster and more robust than using mt_rand()
(see their code).
Could you also update the README to mention the CakePHP support? |
Of course, I could add CakePHP support to the README and I can also make all the commented changes (just need to make sure why it should be different from the Propel ORM). Thanks for considering it :) |
@jadb, can you fix CI errors? |
Sorry, been away. I will look at them over the weekend. |
This looks quite good, @fzaninotto anything blocking this merge? Would love to start using this with the new CakePHP ORM :) |
👍 |
Merged, thanks a lot! |
Thanks everyone! :) |
<3 I'm super-excited about this :) |
@josegonzalez this should interest you too: https://github.com/gourmet/faker |
No description provided.