Skip to content
This repository has been archived by the owner on Dec 11, 2020. It is now read-only.

Add CakePHP ORM #428

Merged
merged 5 commits into from
Dec 5, 2014
Merged

Add CakePHP ORM #428

merged 5 commits into from
Dec 5, 2014

Conversation

jadb
Copy link
Contributor

@jadb jadb commented Sep 24, 2014

No description provided.

};
case 'integer':
return function() {
return mt_rand(0, intval('2147483647'));
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not use `randomNumber()?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can change those, I took those directly from here.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The randomFloat formatter and others were probably added after the Propel ORM populator. But they are faster and more robust than using mt_rand() (see their code).

@fzaninotto
Copy link
Owner

Could you also update the README to mention the CakePHP support?

@jadb
Copy link
Contributor Author

jadb commented Sep 24, 2014

Of course, I could add CakePHP support to the README and I can also make all the commented changes (just need to make sure why it should be different from the Propel ORM).

Thanks for considering it :)

@aivus
Copy link
Contributor

aivus commented Oct 28, 2014

@jadb, can you fix CI errors?

@jadb
Copy link
Contributor Author

jadb commented Nov 8, 2014

Sorry, been away. I will look at them over the weekend.

@josegonzalez
Copy link

This looks quite good, @fzaninotto anything blocking this merge? Would love to start using this with the new CakePHP ORM :)

@lorenzo
Copy link

lorenzo commented Dec 5, 2014

👍

fzaninotto added a commit that referenced this pull request Dec 5, 2014
@fzaninotto fzaninotto merged commit eebe556 into fzaninotto:master Dec 5, 2014
@fzaninotto
Copy link
Owner

Merged, thanks a lot!

@jadb
Copy link
Contributor Author

jadb commented Dec 5, 2014

Thanks everyone! :)

@josegonzalez
Copy link

<3 I'm super-excited about this :)

@jadb
Copy link
Contributor Author

jadb commented Dec 5, 2014

@josegonzalez this should interest you too: https://github.com/gourmet/faker

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants