-
Notifications
You must be signed in to change notification settings - Fork 305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tracking issue for web support #315
Comments
Some implementation notes:
|
Great work and I am looking forward to it!
No problem. In JS people use objects very frequently.
Interesting... Firstly, I see Rust can use threads happily with wasm https://web.dev/webassembly-threads/. So I guess at the pure Rust side it should be no problem? |
I might try this. The only reason I didn't initially is that I wanted to make use of wasm_bindgen a bit more, but doing it this way may cut down some proc macro calls.
Yeah, I'm under the impression that Rust WASM threads right now are completely in userland, so any solution will be highly specific to a certain set of libraries.
There's SharedWorker, which is similar in spirit but the API is a bit different. This actually gave me a good idea, but it will be a while before I can implement it. |
I think comlink can help clean up the code considerably, also helps my sanity as well. |
I agree. Both approaches seem good.
Sounds good. I guess we cannot use comlink directly since that is a JS lib. But maybe we can port it (or rewrite it) in Dart, and since it is only 1KB in size, it should not be too hard. Or maybe we can let Dart call JS. |
The above line is added to README |
Btw curious how is this going on? I am trying to find some time working on this. (I re-encounter this when editing the doc) |
I've been busy and not actively using this library, so progress might be a bit slow. |
Take your time! Just want to know the progress such that when I start working on implementing this I do not reinvent the wheel |
Btw may I make https://github.com/Desdaemon/flutter_rust_bridge/tree/wasm_bindgen a draft PR? Since draft PRs can be more easily reviewed and read. And I noticed it may need some refactoration b/c of my refactoration yesterday... Sorry I did not notice there is this branch since I only checked the PR page. I can rebase for it. |
I took a quick look at that branch, it seems that there are quite a lot of conflicts now... |
No problem. I can refactor code of that branch as well if you like. Indeed the big refactoration of this repo I have done a few days ago is not something magic: The core thing is to move some code to separate files. |
Any ETA when this will be available in the main branch? |
@tojocky You are welcome to contribute to the PR! (@Desdaemon has been working on this and has already made some progress) @Desdaemon Maybe we can make it a draft PR, such that it is easier to track the progress and we will not accidentally merge it without finished? |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
what's the status of web support? |
Still ongoing, no ETA yet sorry. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Looks great! Cannot wait to see the PR and get it merged :) |
That's great. this is a great project. |
Already merged :) |
This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new issue. |
This issue tracks upcoming web support for the library, most of the progress is done on the
wasm_bindgen
wasm_workers
branch.Merge web shim for RawSendPort and store_dart_post_cobject to upstreamUseMessagePort
Tree-shake unusedjs-sys
bindingsSend
Also see #295
The text was updated successfully, but these errors were encountered: