-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix compile when install the newest version #1232
Conversation
cargo install flutter_rust_bridge_codegen v1.77.1 ``` Compiling flutter_rust_bridge_codegen v1.77.1 error[E0451]: field `config_path` of struct `Config` is private | 99 | ..Default::default() | ^^^^^^^^^^^^^^^^^^ field `config_path` is private For more information about this error, try `rustc --explain E0451`. error: could not compile `flutter_rust_bridge_codegen` due to previous error warning: build failed, waiting for other jobs to finish... error: failed to compile `flutter_rust_bridge_codegen v1.77.1`, intermediate artifacts can be found at ```
Hi! Thanks for opening this pull request! 😄 |
Seem related: mozilla/cbindgen#841 |
LGTM after CI is green! More specifically, only need to worry about |
Hmm, for this linter error, I guess we can suppress it there, since it is a false positive.
|
I think the better solution to this problem would be locking |
Mozilla fixed it. Build is working again. |
So... shall I close the PR? |
I don't think you should merge this one, as it only adds a couple extra useless assignments and it doesn't really add any functionality. But it's totally up to you :-) |
I checked a bit about the mozilla issue. Seems that I should keep it open and see what happens to the next breaking version of cbindgen. If that version still contains this breaking change, then we will need to eventually do this change I guess. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
cargo install flutter_rust_bridge_codegen v1.77.1