Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix invalid sdk spec syntax #1331

Merged
merged 1 commit into from
Aug 24, 2023
Merged

fix invalid sdk spec syntax #1331

merged 1 commit into from
Aug 24, 2023

Conversation

aran
Copy link
Contributor

@aran aran commented Aug 24, 2023

Changes

Fixes a typo in frb_dart/pubspec.yaml. Before: red squiggles in vscode due to pubspec.json validation. After: no squiggles.

Checklist

  • An issue to be fixed by this PR is listed above.
  • New tests are added to ensure new features are working. End-to-end tests are usually in the ./frb_example/pure_dart example, more specifically, rust/src/api.rs and dart/lib/main.dart.
  • The code generator is run and the code is formatted (via just precommit).
  • If this PR adds/changes features, documentations (in the ./book folder) are updated.
  • CI is passing.

@fzyzcjy fzyzcjy merged commit 545e081 into fzyzcjy:master Aug 24, 2023
21 of 24 checks passed
@welcome
Copy link

welcome bot commented Aug 24, 2023

Hi! Congrats on merging your first pull request! 🎉

@fzyzcjy
Copy link
Owner

fzyzcjy commented Aug 24, 2023

LGTM, thanks!

@fzyzcjy
Copy link
Owner

fzyzcjy commented Aug 24, 2023

@all-contributors please add @aran for code

@allcontributors
Copy link
Contributor

@fzyzcjy

I've put up a pull request to add @aran! 🎉

@aran aran deleted the frb_dart_typo branch August 24, 2023 14:52
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants