Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No need to let user write AssertUnwindSafe everywhere #1574

Merged
merged 20 commits into from
Jan 1, 2024
Merged

Conversation

fzyzcjy
Copy link
Owner

@fzyzcjy fzyzcjy commented Jan 1, 2024

Changes

Close #1543
Close #1573

Checklist

  • An issue to be fixed by this PR is listed above.
  • New tests are added to ensure new features are working. Please refer to this page to see how to add a test.
  • ./frb_internal precommit --mode slow (or fast) is run (it internal runs code generator, does auto formatting, etc).
  • If this PR adds/changes features, documentations (in the ./website folder) are updated.
  • CI is passing. Please refer to this page to see how to solve a failed CI.

Remark for PR creator

  • ./frb_internal --help shows utilities for development.
  • If fzyzcjy does not reply for a few days, maybe he just did not see it, so please ping him.

Copy link

codecov bot commented Jan 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (44e67a2) 99.23% compared to head (5671cf3) 99.23%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1574      +/-   ##
==========================================
- Coverage   99.23%   99.23%   -0.01%     
==========================================
  Files         341      341              
  Lines       13276    13268       -8     
==========================================
- Hits        13174    13166       -8     
  Misses        102      102              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fzyzcjy fzyzcjy marked this pull request as ready for review January 1, 2024 11:34
@fzyzcjy fzyzcjy merged commit c0c7d24 into master Jan 1, 2024
80 of 81 checks passed
@fzyzcjy fzyzcjy deleted the feat/1543 branch January 1, 2024 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Async functions/methods that take mutable arguments are funky Discussions about UnwindSafe/RefUnwindSafe
1 participant