Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support providing configuration both by command line and by config file at the same time #2119

Merged
merged 18 commits into from
Jun 20, 2024

Conversation

fzyzcjy
Copy link
Owner

@fzyzcjy fzyzcjy commented Jun 20, 2024

Changes

Close #1596

Checklist

  • An issue to be fixed by this PR is listed above.
  • New tests are added to ensure new features are working. Please refer to this page to see how to add a test.
  • ./frb_internal precommit --mode slow (or fast) is run (it internal runs code generator, does auto formatting, etc).
  • If this PR adds/changes features, documentations (in the ./website folder) are updated.
  • CI is passing. Please refer to this page to see how to solve a failed CI.

Remark for PR creator

  • ./frb_internal --help shows utilities for development.
  • If fzyzcjy does not reply for a few days, maybe he just did not see it, so please ping him.

@fzyzcjy fzyzcjy marked this pull request as ready for review June 20, 2024 01:27
Copy link

codecov bot commented Jun 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.12%. Comparing base (3ed6c2f) to head (be52808).
Report is 22 commits behind head on master.

Current head be52808 differs from pull request most recent head 8ec6f39

Please upload reports for the commit 8ec6f39 to get more accurate results.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2119   +/-   ##
=======================================
  Coverage   99.11%   99.12%           
=======================================
  Files         486      486           
  Lines       19656    19676   +20     
=======================================
+ Hits        19482    19503   +21     
+ Misses        174      173    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fzyzcjy fzyzcjy merged commit 40809a2 into master Jun 20, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[codegen] Overriding options from arguments while still using the config file
1 participant