Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix codegen halt when having boxed trait objects #2180

Merged
merged 15 commits into from
Jul 3, 2024
Merged

Fix codegen halt when having boxed trait objects #2180

merged 15 commits into from
Jul 3, 2024

Conversation

fzyzcjy
Copy link
Owner

@fzyzcjy fzyzcjy commented Jul 3, 2024

Changes

Close #2170

Checklist

  • An issue to be fixed by this PR is listed above.
  • New tests are added to ensure new features are working. Please refer to this page to see how to add a test.
  • ./frb_internal precommit --mode slow (or fast) is run (it internal runs code generator, does auto formatting, etc).
  • If this PR adds/changes features, documentations (in the ./website folder) are updated.
  • CI is passing. Please refer to this page to see how to solve a failed CI.

Remark for PR creator

  • ./frb_internal --help shows utilities for development.
  • If fzyzcjy does not reply for a few days, maybe he just did not see it, so please ping him.

@fzyzcjy fzyzcjy marked this pull request as ready for review July 3, 2024 02:17
Copy link

codecov bot commented Jul 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.07%. Comparing base (bfc005a) to head (0906a1f).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2180   +/-   ##
=======================================
  Coverage   99.07%   99.07%           
=======================================
  Files         487      487           
  Lines       20153    20160    +7     
=======================================
+ Hits        19967    19974    +7     
  Misses        186      186           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fzyzcjy fzyzcjy merged commit a44f789 into master Jul 3, 2024
136 of 137 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Panic on codegen "Parse HIR" phase when defining private type
1 participant