Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dart fix command line arg #2288

Merged
merged 8 commits into from
Sep 12, 2024
Merged

Fix dart fix command line arg #2288

merged 8 commits into from
Sep 12, 2024

Conversation

fzyzcjy
Copy link
Owner

@fzyzcjy fzyzcjy commented Sep 11, 2024

/cc @AlexV525

Otherwise it error like:

6.8s] Parse ⠂
[2024-09-11T12:20:37.601Z WARN frb_codegen/src/library/commands/command_runner.rs:153] command=cd "/Volumes/MyExternal/ExternalRefCode/flutter_rust_bridge/frb_example/dart_minimal" && "sh" "-c" "\"dart\" \"fix\" \"--apply\" \"lib/src/rust/api/minimal.dart\" \"lib/src/rust/frb_generated.io.dart\" \"lib/src/rust/frb_generated.web.dart\" \"lib/src/rust/frb_generated.dart\"" stdout= stderr=Only one file or directory is expected.

Usage: dart fix [arguments]
-h, --help                      Print this usage information.
-n, --dry-run                   Preview the proposed changes but make no changes.
    --apply                     Apply the proposed changes.
    --code=<code1,code2,...>    Apply fixes for one (or more) diagnostic codes.

Run "dart help" to see global options.

[2024-09-11T12:20:37.601Z WARN frb_codegen/src/library/codegen/polisher/mod.rs:93] Fail to execute_dart_fix, but continue to run.
Error details: Err(Command execution failed: Only one file or directory is expected.

Usage: dart fix [arguments]
-h, --help                      Print this usage information.
-n, --dry-run                   Preview the proposed changes but make no changes.
    --apply                     Apply the proposed changes.
    --code=<code1,code2,...>    Apply fixes for one (or more) diagnostic codes.

Run "dart help" to see global options.
)
[12.6s] Parse  
  └── [12.6s] Cargo expand & syn parse  
  └── [0.0s] Parse HIR  
  └── [0.0s] Parse MIR  
[0.0s] Generate  
[1.4s] Polish  
  └── [0.2s] Run Dart fix  
  └── [1.1s] Run Dart formatter  
  └── [0.1s] Run Rust formatter                                                                                          Done!

@fzyzcjy fzyzcjy changed the title Fix dart fix command line arg Fix dart fix command line arg and error when integrate Sep 11, 2024
@fzyzcjy fzyzcjy changed the title Fix dart fix command line arg and error when integrate Fix dart fix command line arg Sep 11, 2024
Copy link

codecov bot commented Sep 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.97%. Comparing base (870e5fc) to head (8e613e8).
Report is 15 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2288   +/-   ##
=======================================
  Coverage   98.97%   98.97%           
=======================================
  Files         490      490           
  Lines       20286    20276   -10     
=======================================
- Hits        20078    20069    -9     
+ Misses        208      207    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fzyzcjy fzyzcjy merged commit 9ab7435 into master Sep 12, 2024
137 checks passed
@fzyzcjy fzyzcjy deleted the feat/12561 branch September 12, 2024 00:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant