Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix struct field does not handle custom serializers #2294

Merged
merged 32 commits into from
Sep 12, 2024
Merged

Conversation

fzyzcjy
Copy link
Owner

@fzyzcjy fzyzcjy commented Sep 12, 2024

Changes

Close #2212
Close #2201

Checklist

  • An issue to be fixed by this PR is listed above.
  • New tests are added to ensure new features are working. Please refer to this page to see how to add a test.
  • ./frb_internal precommit --mode slow (or fast) is run (it internal runs code generator, does auto formatting, etc).
  • If this PR adds/changes features, documentations (in the ./website folder) are updated.
  • CI is passing. Please refer to this page to see how to solve a failed CI.

Remark for PR creator

  • ./frb_internal --help shows utilities for development.
  • If fzyzcjy does not reply for a few days, maybe he just did not see it, so please ping him.

@fzyzcjy fzyzcjy changed the base branch from master to feat/2272 September 12, 2024 03:12
@fzyzcjy fzyzcjy changed the base branch from feat/2272 to feat/12562 September 12, 2024 03:13
@fzyzcjy fzyzcjy changed the base branch from feat/12562 to master September 12, 2024 03:18
Copy link

codecov bot commented Sep 12, 2024

Codecov Report

Attention: Patch coverage is 98.43750% with 1 line in your changes missing coverage. Please review.

Project coverage is 98.95%. Comparing base (5608d3d) to head (2e0afc0).
Report is 33 commits behind head on master.

Files with missing lines Patch % Lines
...degen/src/library/codegen/ir/mir/custom_ser_des.rs 80.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2294   +/-   ##
=======================================
  Coverage   98.94%   98.95%           
=======================================
  Files         491      492    +1     
  Lines       20289    20313   +24     
=======================================
+ Hits        20075    20100   +25     
+ Misses        214      213    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fzyzcjy fzyzcjy merged commit 7a1092c into master Sep 12, 2024
134 of 137 checks passed
@fzyzcjy fzyzcjy deleted the feat/12568 branch September 12, 2024 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Rust Ipv4Addr, Ipv6Addr to Dart InternetAddressType class Use #[frb(ignore)] on struct fields
1 participant