Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove importing dart:js_util and generalize SSE codec type handling #2295

Merged
merged 11 commits into from
Sep 13, 2024

Conversation

fzyzcjy
Copy link
Owner

@fzyzcjy fzyzcjy commented Sep 12, 2024

Changes

Close #2237

Checklist

  • An issue to be fixed by this PR is listed above.
  • New tests are added to ensure new features are working. Please refer to this page to see how to add a test.
  • ./frb_internal precommit --mode slow (or fast) is run (it internal runs code generator, does auto formatting, etc).
  • If this PR adds/changes features, documentations (in the ./website folder) are updated.
  • CI is passing. Please refer to this page to see how to solve a failed CI.

Remark for PR creator

  • ./frb_internal --help shows utilities for development.
  • If fzyzcjy does not reply for a few days, maybe he just did not see it, so please ping him.

@fzyzcjy fzyzcjy changed the title Support the new Dart language feature web WASM Support Dart compiled to wasm Sep 12, 2024
@fzyzcjy fzyzcjy changed the title Support Dart compiled to wasm Remove importing dart:js_util Sep 12, 2024
@fzyzcjy fzyzcjy changed the title Remove importing dart:js_util Remove importing dart:js_util and generalize SSE codec type handling Sep 12, 2024
Copy link

codecov bot commented Sep 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.95%. Comparing base (7a1092c) to head (07dc9a6).
Report is 12 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2295      +/-   ##
==========================================
+ Coverage   98.94%   98.95%   +0.01%     
==========================================
  Files         492      493       +1     
  Lines       20313    20317       +4     
==========================================
+ Hits        20098    20104       +6     
+ Misses        215      213       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fzyzcjy fzyzcjy merged commit 7fc8ab9 into master Sep 13, 2024
137 checks passed
@fzyzcjy fzyzcjy deleted the feat/12564 branch September 13, 2024 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dart2Wasm not working because of dart:js_util usage
1 participant