Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support providing relative paths to configuration file #2320

Merged
merged 3 commits into from
Sep 28, 2024

Conversation

patmuk
Copy link
Contributor

@patmuk patmuk commented Sep 26, 2024

Changes

fixes #2166

Checklist

  • An issue to be fixed by this PR is listed above.
  • New tests are added to ensure new features are working. Please refer to this page to see how to add a test.
  • ./frb_internal precommit --mode slow (or fast) is run (it internal runs code generator, does auto formatting, etc).
  • If this PR adds/changes features, documentations (in the ./website folder) are updated.
  • CI is passing. Please refer to this page to see how to solve a failed CI.

Remark for PR creator

  • ./frb_internal --help shows utilities for development.
  • If fzyzcjy does not reply for a few days, maybe he just did not see it, so please ping him.

@patmuk patmuk changed the title canolies the base dir earlier cannolies the base dir earlier Sep 26, 2024
@patmuk patmuk changed the title cannolies the base dir earlier fixes #2166 Sep 26, 2024
@patmuk patmuk changed the title fixes #2166 fixes #2166 (providing a relative path to frb.yaml) Sep 26, 2024
@fzyzcjy
Copy link
Owner

fzyzcjy commented Sep 27, 2024

Looks great! Maybe we can fix the CI by changing what it complains, e.g.

diff --git a/frb_example/flutter_via_create/pubspec.lock b/frb_example/flutter_via_create/pubspec.lock
index eadc974..ad3f38c 100644
--- a/frb_example/flutter_via_create/pubspec.lock
+++ b/frb_example/flutter_via_create/pubspec.lock
@@ -297,10 +297,10 @@ packages:
     dependency: transitive
     description:
       name: web
-      sha256: d43c1d6b787bf0afad444700ae7f4db8827f701bc61c255ac8d328c6f4d52062
+      sha256: cd3543bd5798f6ad290ea73d210f423502e71900302dde696f8bff84bf89a1cb
       url: "https://pub.dev/"
     source: hosted
-    version: "1.0.0"
+    version: "1.1.0"
   webdriver:
     dependency: transitive
     description:

@patmuk
Copy link
Contributor Author

patmuk commented Sep 27, 2024

Thanks :)
Yes - I have the same "problem" in my other PR. I think that locally the dependencies are getting updated, while on CI they are compared to the old once. Note that the pubspec.yaml isn't changed - the new versions are still valid.
Thus it is very likely that a user's local system would update as well.

I think it would be best to use the new pub spec.locks - but I did not look into the CI config to see how/why it compares with the old ones.

But I don't have a strong opinion on that, I could revert the pubspec.lock's to the older state as well.

@fzyzcjy
Copy link
Owner

fzyzcjy commented Sep 27, 2024

I think it would be best to use the new pub spec.locks - but I did not look into the CI config to see how/why it compares with the old ones.

Without detailed exploration, my first guess: because the flutter version is locked

@fzyzcjy fzyzcjy mentioned this pull request Sep 27, 2024
5 tasks
@patmuk
Copy link
Contributor Author

patmuk commented Sep 27, 2024

I think it would be best to use the new pub spec.locks - but I did not look into the CI config to see how/why it compares with the old ones.

Without detailed exploration, my first guess: because the flutter version is locked

Oh, that is very likely! I will revert the podspec.locks.

@patmuk
Copy link
Contributor Author

patmuk commented Sep 27, 2024

Ah, actually no one of us committed any pubspec.lock files.

I guess that there is just a new package of "web"available (1.0.0 -> 1.1.0) the build process updated to?

@fzyzcjy
Copy link
Owner

fzyzcjy commented Sep 28, 2024

Yes I think so

@fzyzcjy fzyzcjy changed the title fixes #2166 (providing a relative path to frb.yaml) Support providing relative paths to configuration file Sep 28, 2024
@fzyzcjy fzyzcjy merged commit 4e6e837 into fzyzcjy:master Sep 28, 2024
135 checks passed
@patmuk patmuk deleted the fixes-#2166 branch September 28, 2024 03:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

relative path to flutter_rust_bridge.yaml / rust_root is not working
2 participants