-
Notifications
You must be signed in to change notification settings - Fork 300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support providing relative paths to configuration file #2320
Conversation
Looks great! Maybe we can fix the CI by changing what it complains, e.g. diff --git a/frb_example/flutter_via_create/pubspec.lock b/frb_example/flutter_via_create/pubspec.lock
index eadc974..ad3f38c 100644
--- a/frb_example/flutter_via_create/pubspec.lock
+++ b/frb_example/flutter_via_create/pubspec.lock
@@ -297,10 +297,10 @@ packages:
dependency: transitive
description:
name: web
- sha256: d43c1d6b787bf0afad444700ae7f4db8827f701bc61c255ac8d328c6f4d52062
+ sha256: cd3543bd5798f6ad290ea73d210f423502e71900302dde696f8bff84bf89a1cb
url: "https://pub.dev/"
source: hosted
- version: "1.0.0"
+ version: "1.1.0"
webdriver:
dependency: transitive
description: |
Thanks :) I think it would be best to use the new But I don't have a strong opinion on that, I could revert the pubspec.lock's to the older state as well. |
Without detailed exploration, my first guess: because the flutter version is locked |
Oh, that is very likely! I will revert the podspec.locks. |
Ah, actually no one of us committed any pubspec.lock files. I guess that there is just a new package of "web"available (1.0.0 -> 1.1.0) the build process updated to? |
Yes I think so |
Changes
fixes #2166
Checklist
./frb_internal precommit --mode slow
(orfast
) is run (it internal runs code generator, does auto formatting, etc)../website
folder) are updated.Remark for PR creator
./frb_internal --help
shows utilities for development.