🚀 Use `dart_output` when possible for the `dart fix` #2340

AlexV525 · 2024-10-07T04:17:54Z

Changes

Fixes #2316
Fixes #2328

An issue to be fixed by this PR is listed above.
New tests are added to ensure new features are working. Please refer to this page to see how to add a test.
./frb_internal precommit --mode slow (or fast) is run (it internal runs code generator, does auto formatting, etc).
If this PR adds/changes features, documentations (in the ./website folder) are updated.
CI is passing. Please refer to this page to see how to solve a failed CI.

fzyzcjy

Looks good! Only a nit

frb_codegen/src/library/codegen/polisher/mod.rs

fzyzcjy

LGTM!

frb_codegen/src/library/codegen/config/internal_config_parser/mod.rs

AlexV525 added 2 commits October 7, 2024 11:59

🚀 Provide dart_output as an argument and a config field

b15e07d

🚀 Use dart_output when possible for the dart fix

681f371

AlexV525 changed the title ~~Fix/dart command path~~ 🚀 Use dart_output when possible for the dart fix Oct 7, 2024

🔥 Remove config fields

6880075

fzyzcjy reviewed Oct 7, 2024

View reviewed changes

frb_codegen/src/library/codegen/polisher/mod.rs Outdated Show resolved Hide resolved

AlexV525 added 2 commits October 7, 2024 13:17

🚀 Use path only in internal config

282c13d

✅ Update expected outputs

e813147

AlexV525 marked this pull request as ready for review October 8, 2024 02:39

AlexV525 requested a review from fzyzcjy October 8, 2024 02:39

fzyzcjy approved these changes Oct 8, 2024

View reviewed changes

frb_codegen/src/library/codegen/config/internal_config_parser/mod.rs Show resolved Hide resolved

fzyzcjy merged commit 02916db into fzyzcjy:master Oct 8, 2024
135 checks passed

AlexV525 deleted the fix/dart-command-path branch October 8, 2024 03:01