Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: declaration of * hides class member #175

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

feniksa
Copy link

@feniksa feniksa commented Mar 17, 2020

On VS 2019 warning "C4458: declaration of '*' hides class member" . As result, projects that have -Werror can't compile due this warning.

On VS 2019 warning "C4458: declaration of '*' hides class member"
is and error.
@feniksa
Copy link
Author

feniksa commented Mar 18, 2020

Hm, I don't think that verification error somehow connected with changes

@BartSiwek
Copy link

I stumbled upon this because of the same warning firing. Just to add my two cents, but in C++ names beginning with an underscore followed by a capital letter are reserved for standard library as per 17.4.3.1.2 of the standard:

Certain sets of names and function signatures are always reserved to the implementation:

    Each name that contains a double underscore (__) or begins with an underscore followed by an uppercase letter (2.11) is reserved to the implementation for any use.
    Each name that begins with an underscore is reserved to the implementation for use as a name in the global namespace.165

165) Such names are also reserved in namespace ::std (17.4.3.1). 

@qbojj qbojj mentioned this pull request Jul 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants