-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GLM_FORCE_CXX98 on Android #213
Comments
Hi, If you #define GLM_MESSAGES before including <glm.glm.hpp> what does GLM says at compilation time? Android is quite annoying to support with all the toolchains / lib / options and quite depends on GLM users feedback. I think it's worth to try to resolve. Thanks, |
I have added a tentative fix in GLM 0.9.5 branch for GLM 0.9.5.4 release. Let me know if you have any issue with it. Thanks, |
Ok, now I get _nextafter not found instead. With GLM_MESSAGES defined, output of ndk-build is:
|
Ok, I had a closer look at this and have a potential fix: Change the single instance of _nextafter in ulp.inl to detail::nextafter, and it compiles fine on Android. I'll attempt to create a 'pull request', but I kinda suck at git - it's wanting to 'push' first for some reason... |
I tried to replace to file with the new commited one, (I have version 0.9.5.4) and it still failed to compile on android ndk. I changed every line the compiler complained about to detail::nextafter instead of _nextafter and now it compilers both on windows and android. I'm not really familiar with the usage of prev_float and next_float functions within the glm code, so I don't know what long term effect my changes might cause. If someone more knowledgeable than I do managed to solve this, please provide the solution. Thanks in advanced. EDIT: EDIT2: APP_STL := gnustl_static |
Not sure if this is a 'bug' or even worth worrying about, but I'm having to #define GLM_FORCE_CXX98 on Android, or I get a bunch of 'nextafter is not a member of std' errors when building for Android.
My application.mk file includes:
APP_STL := gnustl_static
NDK_TOOLCHAIN_VERSION :=4.8
...which appear to be required by C++11, which I use via CFLAGS in android.mk
Feel free to ignore, just a bit weird and I thought it might be worth mentioning...
The text was updated successfully, but these errors were encountered: