Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

glm::fma can use the std::fma implementation #969

Closed
JonasGilg opened this issue Nov 4, 2019 · 1 comment
Closed

glm::fma can use the std::fma implementation #969

JonasGilg opened this issue Nov 4, 2019 · 1 comment
Assignees
@Groovounet
Labels
core enhancement
Milestone
GLM 0.9.9

Comments

@JonasGilg
Copy link

Currently glm::fma implementation just returns a * b + c, which defeats the purpose of fma.
It should instead use the std::fma function, which invokes an optimized machine instruction if available. This gives higher precision in this calculation, which is the whole reason why fma exists at all.
Groovounet added a commit that referenced this issue Nov 6, 2019
@Groovounet
Added fma implementation based on std::fma #969
95b1cdb
@Groovounet Groovounet added this to the GLM 0.9.9 milestone Nov 6, 2019
@Groovounet Groovounet self-assigned this Nov 6, 2019
@Groovounet
Copy link
Member

This issue is resolved in master branch for GLM 0.9.9.7 release.

Thanks for reporting

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Groovounet Groovounet

Labels
core enhancement
Projects
None yet
Milestone
GLM 0.9.9
Development

No branches or pull requests
2 participants
@Groovounet @JonasGilg