Removed use of =default for vector types

[patrikhuber]

Defaulting the copy constructor and copy assignment operators causes compiler errors when the type T is not trivially copyable. In that case, explicitly defined copy ctor and assignment are required. This PR removes the #ifdefs around the existing operators, so they're always used.

[patrikhuber]

This PR does not deal with the case yet when GLM_FORCE_NO_CTOR_INIT is #defined. If you approve of this PR, I'll update it so it fixes that case too.

[Groovounet]

I don't think this is the proper fix but that should be or great help to build a define allowing the behavior you are looking for.

Thanks,
Chirstophe

[patrikhuber]

Are you considering merging this PR? It would be nice to lift this artificial restriction of not being able to put in non-trivially copyable types because of the =default. As it is now, non-trivially-copyable types are allowed when the compiler doesn't have =default, and they're not when the compiler has it. That's a weird inconsistency. And actually there's no reason to prevent putting in non-trivially-copyable types at this level.
Also the PR does not change any behaviour if you put in POD types.

In my experience so far with my custom type as T in vec* / mat* / quat*, all of GLMs functionality I've tried worked without any issues whatsoever, the basic math operations work out of the box as well as functions like glm::project and so on. I think that's a big gain.

Thanks very much,
Patrik

[Groovounet]

This issue is partially fixed in master and 0.9.8 branches. I still need to add tests to be good to go.

Thanks for reporting,
Christophe

[patrikhuber]

Looks great! Thank you very much for your effort! :-)