Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SequenceLocation allows for negative start/end coordinates #442

Closed
korikuzma opened this issue Aug 20, 2024 · 0 comments · Fixed by #443
Closed

SequenceLocation allows for negative start/end coordinates #442

korikuzma opened this issue Aug 20, 2024 · 0 comments · Fixed by #443
Assignees
@korikuzma
Labels
bug Something isn't working priority:high High priority

Comments

@korikuzma
Copy link
Contributor

https://github.com/ga4gh/vrs/blob/2.x/schema/vrs/json/SequenceLocation#L77

https://github.com/ga4gh/vrs/blob/2.x/schema/vrs/json/SequenceLocation#L88

We do not do any validation at the moment. We should add validation checks to follow what is stated in the descriptions.
@korikuzma korikuzma added bug Something isn't working priority:high High priority labels Aug 20, 2024
@korikuzma korikuzma self-assigned this Aug 20, 2024
korikuzma added a commit that referenced this issue Aug 28, 2024
@korikuzma
fix: do not allow SequenceLocation to have negative start/end v…
2f46958 
…alues

close #442

* Add model_validators to `Range` and `SequenceLocation`
@korikuzma korikuzma mentioned this issue Aug 28, 2024
Merged
korikuzma added a commit that referenced this issue Aug 28, 2024
@korikuzma
fix: do not allow SequenceLocation to have negative start/end v…
ae79175 
…alues

close #442

* Add model_validators to `Range` and `SequenceLocation`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@korikuzma korikuzma

Labels
bug Something isn't working priority:high High priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: do not allow SequenceLocation to have negative start/end v… ga4gh/vrs-python
1 participant
@korikuzma