Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: get make test to run #396

Merged
merged 1 commit into from
Apr 11, 2024
Merged

fix: get make test to run #396

merged 1 commit into from
Apr 11, 2024

Conversation

korikuzma
Copy link
Contributor

close #395

* In #388 we forgot to update the commands to remove setup.py since it
  was removed. This commit removes references to setup.py and setup.cfg
in Makefile
@korikuzma korikuzma added bug Something isn't working priority:medium Medium priority labels Apr 10, 2024
@korikuzma korikuzma self-assigned this Apr 10, 2024
@korikuzma korikuzma requested review from a team as code owners April 10, 2024 20:21
Copy link
Contributor

@jsstevenson jsstevenson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UGH yeah.

calling pytest with setup.py is discouraged per... a thing in their docs somewhere and should similarly be fixed throughout biocommons

@korikuzma korikuzma merged commit ff7451d into main Apr 11, 2024
10 checks passed
@korikuzma korikuzma deleted the issue-395 branch April 11, 2024 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working priority:medium Medium priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

make test not working
2 participants