Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only attempt to create allele if values were extracted #401

Merged
merged 1 commit into from
Apr 19, 2024
Merged

Only attempt to create allele if values were extracted #401

merged 1 commit into from
Apr 19, 2024

Conversation

ehclark
Copy link
Contributor

@ehclark ehclark commented Apr 17, 2024

See #400

Updated _from_hgvs() to only call _create_allele() is value extraction was successful. Otherwise returns None to indicate description could not be parsed as HGVS.

@ehclark
Only attempt to create allele if values were extracted
7391255 
Add test case to translate from an invalid variant description
@ehclark ehclark requested review from a team as code owners April 17, 2024 12:29
@ehclark ehclark linked an issue Apr 17, 2024 that may be closed by this pull request
Passing an invalid variant description to AlleleTranslator.translate_from() throws TypeError #400
Closed
jsstevenson
jsstevenson approved these changes Apr 17, 2024
View reviewed changes
Copy link
Contributor

@jsstevenson jsstevenson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@larrybabb larrybabb merged commit 1c9e4ab into main Apr 19, 2024
8 checks passed
@larrybabb larrybabb deleted the issue-400 branch April 19, 2024 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsstevenson jsstevenson jsstevenson approved these changes

@larrybabb larrybabb larrybabb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Passing an invalid variant description to AlleleTranslator.translate_from() throws TypeError
3 participants
@ehclark @larrybabb @jsstevenson