Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove _internal directories #423

Merged
merged 16 commits into from
Jul 10, 2024
Merged

refactor: remove _internal directories #423

merged 16 commits into from
Jul 10, 2024

Conversation

korikuzma
Copy link
Contributor

close #407

Remove _internal directories and move files up a directory

Duplicate of #421 but I accidentally added commit to branch that should have not been there. 🤦

korikuzma added 15 commits June 26, 2024 08:09
close #415
* only support 3 most recent python versions (3.10, 3.11, 3.12)
* change development python version from 3.10 to 3.12
* re-run cassettes
* ordered:false -> serializer should always sort the array before computing the digest so that regardless of the order, the digest always comes out the same
* ordered: true -> do not sort the items before digesting, so digests can be different based on ordering of array
close #407

* Remove _internal directories and move files up a directory
@korikuzma korikuzma added priority:high High priority technical debt A feature/requirement implemented in a sub-optimal way & must be re-written. Contrast to "cleanup" labels Jul 10, 2024
@korikuzma korikuzma self-assigned this Jul 10, 2024
@korikuzma korikuzma requested review from a team as code owners July 10, 2024 14:59
@korikuzma korikuzma merged commit 57d472e into main Jul 10, 2024
6 checks passed
@korikuzma korikuzma deleted the issue-407 branch July 10, 2024 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority:high High priority technical debt A feature/requirement implemented in a sub-optimal way & must be re-written. Contrast to "cleanup"
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Do away with "private" modules
2 participants