feat: enable logging in annotator CLI #450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
korikuzma
reviewed
Sep 11, 2024
| @@ -36,10 +37,55 @@ class SeqRepoProxyType(str, Enum): | |||
| @click.group() | |||
| def _cli() -> None: | |||
| """Annotate input files with VRS variation objects.""" | |||
| logging.basicConfig( | |||
| filename="vrs-annotate.log", | |||
There was a problem hiding this comment.
This made me realize that we should probably rename class / module to vrs-annotate if we plan on supporting more than just vcfs. Can create a new issue for this
There was a problem hiding this comment.
@korikuzma yeah I thought about doing that in the previous PR and wasn't sure about it, but would be happy to make a PR for it if we think it makes sense to do so now. At minimum I think it'd be nice to change "annotation" to "annotator" in the module name to match the tense of the translator module.
korikuzma
approved these changes
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.