Avoid using self in service.ts - to avoid issue with through
#95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willstott101
commented
Jan 24, 2022
| } | ||
| respStream.queue(Buffer.from('0000')); | ||
| respStream.queue(null); | ||
| } | ||
|
|
||
| self.emit.bind(self, 'exit'); |
There was a problem hiding this comment.
I also went ahead and fixed this no-op.
gabrielcsapo
approved these changes
Jan 25, 2022
|
Published as 1.0.0-beta.2. |
gabrielcsapo
pushed a commit
that referenced
this pull request
Jan 25, 2022
gabrielcsapo
added a commit
that referenced
this pull request
Jul 11, 2022
- Removes node support from node@<16 (@gabrielcsapo) - Bugfix: Fix logging on response streams. (#96) (@willstott101) - Avoid using self in service.ts - to avoid issue with through (#95) (@willstott101) - Migrates to typescript (@5GameMaker @gabrielcsapo) - Removes node support from node@<14
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been seeing errors like this during shutdown of my integration test suite.
by switching to using the
throughstream via closure seems to fix the issue. Whilst in there I went ahead and tidied up the usage ofselfas I believe when operating inside closures of a class method...thisshould always refer to the same thing. By removing theselfwe can avoid temptation to re-definethisin any closure.