Harden Azure Hybrid Benefit toggling

gabrielweyer · Jan 12, 2024 · 1695096 · 1695096
1 parent 94ee7d9
commit 1695096
Show file tree

Hide file tree

Showing 2 changed files with 27 additions and 6 deletions.
diff --git a/parser/src/azurePortalExtensions.ts b/parser/src/azurePortalExtensions.ts
@@ -1,10 +1,10 @@
 import * as puppeteer from 'puppeteer';
 import { PartialVmPricing, VmPricing } from "./vmPricing";
-import { isSelectedSelect, setSelect } from './puppeteerExtensions';
-import { json } from 'stream/consumers';
+import { isSelectedSelect, setSelect, isSelectedCheckbox } from './puppeteerExtensions';
 
 export class AzurePortal {
   private p: puppeteer.Page;
+  private azureHybridBenefitButtonSelector = 'button#isAhb';
 
   constructor(page: puppeteer.Page) {
     this.p = page;
@@ -73,8 +73,7 @@ export class AzurePortal {
 
     if (hasHybridBenefit) {
       savingsPlanWithHybridBenefits = savingsPlanPricing;
-      await this.p.click('button#isAhb');
-      await this.waitForPriceWithoutHybridBenefits();
+      await this.hideAzureHybridBenefit();
       savingsPlansWithoutHybridBenefits = await this.p.evaluate(() => getPricing());
 
       if (savingsPlanWithHybridBenefits.length !== savingsPlansWithoutHybridBenefits.length) {
@@ -110,8 +109,7 @@ export class AzurePortal {
 
     if (hasHybridBenefit) {
       reservedWithoutHybridBenefits = reservedPricing;
-      await this.p.click('button#isAhb');
-      await this.waitForPriceWithHybridBenefits();
+      await this.showAzureHybridBenefit();
       reservedWithHybridBenefits = await this.p.evaluate(() => getPricing());
 
       if (reservedWithoutHybridBenefits.length !== reservedWithHybridBenefits.length) {
@@ -229,6 +227,24 @@ export class AzurePortal {
     );
   }
 
+  private async hideAzureHybridBenefit(): Promise<void> {
+    if (!await isSelectedCheckbox(this.p, this.azureHybridBenefitButtonSelector)) {
+      return;
+    }
+
+    await this.p.click(this.azureHybridBenefitButtonSelector);
+    await this.waitForPriceWithoutHybridBenefits();
+  }
+
+  private async showAzureHybridBenefit(): Promise<void> {
+    if (await isSelectedCheckbox(this.p, this.azureHybridBenefitButtonSelector)) {
+      return;
+    }
+
+    await this.p.click(this.azureHybridBenefitButtonSelector);
+    await this.waitForPriceWithHybridBenefits();
+  }
+
   private async waitForPriceWithoutHybridBenefits(): Promise<void> {
     await this.p.waitForFunction(
       () => {

diff --git a/parser/src/puppeteerExtensions.ts b/parser/src/puppeteerExtensions.ts
@@ -19,6 +19,11 @@ export async function isSelectedSelect(page: puppeteer.Page, selector: string, v
   return selectedValue === value;
 }
 
+export async function isSelectedCheckbox(page: puppeteer.Page, selector: string): Promise<boolean> {
+  const value = await page.$eval(selector, node => (<HTMLButtonElement> node).value);
+  return value === 'true';
+}
+
 async function getSelectedValue(page: puppeteer.Page, selector: string): Promise<string> {
   const fullSelector = getSelectFullSelector(selector);
   await page.waitForSelector(fullSelector, { visible: true });