Fix Central Package Management private assets

It doesn't work when specified in the props file. Needs to be specified in the csproj.
gabrielweyer · Jan 9, 2023 · 360d937 · 360d937
1 parent 6f4cf4d
commit 360d937
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 10 deletions.
diff --git a/coster/Directory.Packages.props b/coster/Directory.Packages.props
@@ -6,17 +6,11 @@
     <PackageVersion Include="Nuke.Common" Version="6.3.0" />
     <PackageVersion Include="CsvHelper" Version="30.0.1" />
     <PackageVersion Include="Newtonsoft.Json" Version="13.0.2" />
-    <PackageVersion Include="coverlet.collector" Version="3.2.0">
-      <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
-      <PrivateAssets>all</PrivateAssets>
-    </PackageVersion>
+    <PackageVersion Include="coverlet.collector" Version="3.2.0" />
     <PackageVersion Include="FluentAssertions" Version="6.8.0" />
     <PackageVersion Include="Microsoft.NET.Test.Sdk" Version="17.4.1" />
     <PackageVersion Include="xunit" Version="2.4.2" />
-    <PackageVersion Include="xunit.runner.visualstudio" Version="2.4.5">
-      <PrivateAssets>all</PrivateAssets>
-      <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
-    </PackageVersion>
+    <PackageVersion Include="xunit.runner.visualstudio" Version="2.4.5" />
     <GlobalPackageReference Include="Meziantou.Analyzer" Version="2.0.3" />
     <GlobalPackageReference Include="Microsoft.VisualStudio.Threading.Analyzers" Version="17.4.27" />
     <GlobalPackageReference Include="AsyncFixer" Version="1.6.0" />

diff --git a/coster/tests/AzureVmCosterTests/AzureVmCosterTests.csproj b/coster/tests/AzureVmCosterTests/AzureVmCosterTests.csproj
@@ -16,11 +16,17 @@
   </ItemGroup>
 
   <ItemGroup>
-    <PackageReference Include="coverlet.collector" />
+    <PackageReference Include="coverlet.collector">
+      <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
+      <PrivateAssets>all</PrivateAssets>
+    </PackageReference>
     <PackageReference Include="FluentAssertions" />
     <PackageReference Include="Microsoft.NET.Test.Sdk" />
     <PackageReference Include="xunit" />
-    <PackageReference Include="xunit.runner.visualstudio" />
+    <PackageReference Include="xunit.runner.visualstudio">
+      <PrivateAssets>all</PrivateAssets>
+      <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
+    </PackageReference>
     <PackageReference Include="xunit.analyzers" />
   </ItemGroup>