-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade from ISMRMRD to MRD v2 #2
Conversation
This is a very large PR that overhauls the entire Gadgetron code base to upgrade from ISMRMRD to MRDv2, switch to a pure streaming architecture, and remove socket networking from the codebase. Specifically, this PR:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall this looks great. Huge amount of work here. Much more to do, but this sets us up with a basis to work off. Made some minor comments about some additional stuff we can remove and then maybe some things for next steps:
General Comments:
- It would be good with a scheme to parallelize the data download for the tests.
- Perhaps add a readme to say that the test case conversion tools are temporary. We will remove those once we have MRD data converters.
- Next step should be removing XML files and runtime linking.
- We should remove Doxygen (nobody needs that, intellisense is what we use) and Readthedocs and use approach from Tyger.
- We should come up with some other approach to distributed.
- We should have some general "tail" gadget where you choose output format with a parameter.
gadgets/cmr/config/BinningCine/CMR_2DT_RTCine_KspaceBinning_Cloud.xml
Outdated
Show resolved
Hide resolved
The repository settings required a follow-up review. I addressed your feedback and opened issues for next steps. |
No description provided.