Fixing false positive regression on Function Declarations from previo…

…us changes. This change adds a reset to the foundJSXKey to prevent false positives
gaearon · Oct 9, 2015 · d13c8d3 · d13c8d3 · joshblack · Oct 9, 2015
1 parent e2aa5fa
commit d13c8d3
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 0 deletions.
diff --git a/src/index.js b/src/index.js
@@ -315,6 +315,8 @@ export default function ({ Plugin, types: t }) {
             return;
           }
 
+          this.state[foundJSXKey] = false;
+
           // No-op for `render` methods in this visitor
           if (parent.key && parent.key.name === 'render') {
             return;
@@ -342,6 +344,10 @@ export default function ({ Plugin, types: t }) {
             );
           }
 
+          if (t.isFunctionDeclaration(node)) {
+            // console.log(node.body.body.filter(t.isReturnStatement));
+          }
+
           return [
             node,
             t.assignmentExpression('=', bindingId,

diff --git a/test/fixtures/pure-function/expected.js b/test/fixtures/pure-function/expected.js
@@ -78,6 +78,7 @@ exports.NamedExportFunction = NamedExportFunction = _wrapComponent('_$NamedExpor
 function DefaultExportFunction() {
   return _react2['default'].createElement('div', null);
 }
+
 DefaultExportFunction = _wrapComponent('_$DefaultExportFunction')(DefaultExportFunction)
 var ModulePattern = {
   NoProps: _wrapComponent('_$NoProps')(function () {