Work around https://phabricator.babeljs.io/T7298

Fixes #246
gaearon · Apr 18, 2016 · 8bdeaa0 · 8bdeaa0
1 parent 68b9f02
commit 8bdeaa0
Show file tree

Hide file tree

Showing 4 changed files with 59 additions and 17 deletions.
diff --git a/src/babel/index.js b/src/babel/index.js
@@ -65,7 +65,7 @@ module.exports = function(args) {
     }
   }
 
-  const DEFAULT_EXPORT = Symbol();
+  const REGISTRATIONS = Symbol();
   return {
     visitor: {
       ExportDefaultDeclaration(path)  {
@@ -84,34 +84,31 @@ module.exports = function(args) {
           ])
         )
         path.node.declaration = id;
-        path.parent[DEFAULT_EXPORT] = id;
+        path.parent[REGISTRATIONS].push(
+          buildRegistration({
+            ID: id,
+            NAME: t.stringLiteral('default')
+          })
+        );
       },
 
       Program: {
-        enter({ node }) {
-          node[DEFAULT_EXPORT] = null;
-        },
-
-        exit({ node, scope }, { file }) {
-          let registrations = [];
-
+        enter({ node, scope }) {
+          node[REGISTRATIONS] = [];
           for (let id in scope.bindings) {
             const binding = scope.bindings[id];
             if (shouldRegisterBinding(binding)) {
-              registrations.push(buildRegistration({
+              node[REGISTRATIONS].push(buildRegistration({
                 ID: binding.identifier,
                 NAME: t.stringLiteral(id)
               }));
             }
           }
+        },
 
-          if (node[DEFAULT_EXPORT]) {
-            registrations.push(buildRegistration({
-              ID: node[DEFAULT_EXPORT],
-              NAME: t.stringLiteral('default')
-            }));
-          }
-
+        exit({ node, scope }, { file }) {
+          let registrations = node[REGISTRATIONS];
+          node[REGISTRATIONS] = null;
           node.body.push(
             buildTagger({
               FILENAME: t.stringLiteral(file.opts.filename),

diff --git a/test/babel/fixtures/issue-246/.babelrc b/test/babel/fixtures/issue-246/.babelrc
@@ -0,0 +1,4 @@
+{
+  "presets": ["es2015"],
+  "plugins": ["../../../../src/babel"]
+}
diff --git a/test/babel/fixtures/issue-246/actual.js b/test/babel/fixtures/issue-246/actual.js
@@ -0,0 +1,3 @@
+export function spread(...args) {
+  return args.push(1)
+}
diff --git a/test/babel/fixtures/issue-246/expected.js b/test/babel/fixtures/issue-246/expected.js
@@ -0,0 +1,38 @@
+"use strict";
+
+Object.defineProperty(exports, "__esModule", {
+  value: true
+});
+exports.spread = spread;
+function spread() {
+  for (var _len = arguments.length, args = Array(_len), _key = 0; _key < _len; _key++) {
+    args[_key] = arguments[_key];
+  }
+
+  return args.push(1);
+}
+
+(function () {
+  function tagSource(fn, localName) {
+    if (typeof fn !== "function") {
+      return;
+    }
+
+    if (fn.hasOwnProperty("__source")) {
+      return;
+    }
+
+    try {
+      Object.defineProperty(fn, "__source", {
+        enumerable: false,
+        configurable: true,
+        value: {
+          fileName: __FILENAME__,
+          localName: localName
+        }
+      });
+    } catch (err) {}
+  }
+
+  tagSource(spread, "spread");
+})();