makeAssimilatePrototype invokes getters when copying methods

[timnew]

I have React component defined in es6 style class, within it, I declared some getters.
But the getters got executed in makeAssimilatePrototype, which is improper behavior!

class PropertyBinder extends React.Component {
  constructor(props) {
    super(props);

    this.state = new Map({
      childProps: {},
      listeners: {}
    });
    this.onSourceChanged();
  }

  get multiSource() { return this.props.multiSource; }
  get childProps() { return this.state.childProps; }
  get listeners() { return this.state.listeners; }

  // some other code
}

I got following call stack

Uncaught TypeError: Cannot read property 'multiSource' of undefined
  _createClass.get  @   PropertyBinder.jsx:53
  (anonymous function)  @   makeAssimilatePrototype.js:44
  updateStoredPrototype @   makeAssimilatePrototype.js:43
  assimilatePrototype   @   makeAssimilatePrototype.js:62
  patchReactClass   @   makePatchReactClass.js:40
  makeHot   @   makeMakeHot.js:33
  makeExportsHot    @   makeExportsHot.js:17
  (anonymous function)  @   PropertyBinder.jsx:128
  (anonymous function)  @   PropertyBinder.jsx:128
  (anonymous function)  @   PropertyBinder.jsx:129
  (anonymous function)  @   bundle.js:685
  __webpack_require__   @   bundle.js:505
  fn    @   bundle.js:76
  (anonymous function)  @   Setup.jsx:25
  (anonymous function)  @   Setup.jsx:120
  (anonymous function)  @   Setup.jsx:121
  (anonymous function)  @   bundle.js:595
  __webpack_require__   @   bundle.js:505
  fn    @   bundle.js:76
  (anonymous function)  @   route.jsx:19
  (anonymous function)  @   route.jsx:42
  (anonymous function)  @   route.jsx:43
  (anonymous function)  @   bundle.js:553
  __webpack_require__   @   bundle.js:505
  fn    @   bundle.js:76
  (anonymous function)  @   multi_main:3
  (anonymous function)  @   bundle.js:535
  __webpack_require__   @   bundle.js:505
  (anonymous function)  @   bundle.js:528
  (anonymous function)  @   bundle.js:531

[timnew]

To fix this issue, I think it should avoid to read and set property directly, instead call Object.getOwnPropertyDescriptor() to read property and call Object.defineProperty again to override it. This approach should work because descriptor.configurable is set to true by default;

this is what _createClass look like:

"use strict";

var _Object$defineProperty = __webpack_require__(29)["default"];

exports["default"] = (function () {
  function defineProperties(target, props) {
    for (var i = 0; i < props.length; i++) {
      var descriptor = props[i];
      descriptor.enumerable = descriptor.enumerable || false;
      descriptor.configurable = true;
      if ("value" in descriptor) descriptor.writable = true;

      _Object$defineProperty(target, descriptor.key, descriptor);
    }
  }

  return function (Constructor, protoProps, staticProps) {
    if (protoProps) defineProperties(Constructor.prototype, protoProps);
    if (staticProps) defineProperties(Constructor, staticProps);
    return Constructor;
  };
})();

exports.__esModule = true;

/*****************
 ** WEBPACK FOOTER
 ** ./~/babel-runtime/helpers/create-class.js
 ** module id = 23
 ** module chunks = 0
 **/

[gaearon]

This is fixed in the next beta release coming very soon.
Stay tuned.

[gaearon]

Can I ask you to check whether react-hot-loader@2.0.0-alpha solves this issue?
Please provide any feedback on it in this PR: #182