Add checks for node environment variables for use with symlinked reactjs-components #944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -123,6 +123,7 @@ | |||
| "serve-notify": "export NOTIFY=true && npm run serve", | |||
| "scaffold": "./node_modules/.bin/gulp ensureConfig && ./node_modules/.bin/gulp ensureDevProxy", | |||
| "start": "NODE_ENV=development webpack-dev-server --config ./webpack/webpack.dev.babel.js --hot --progress --colors --content-base ./build --host 0.0.0.0 --port $npm_package_config_port", | |||
| "start-reactjs-components-local": "REACTJS_COMPONENTS_LOCAL=true npm start", | |||
There was a problem hiding this comment.
I would prefer we add this to the CONTRIBUTING.md on how to develop with reactjs-components, instead of creating a script here.
jfurrow
changed the title
|
LGTM! 🚢 |
orlandohohmeier
deleted the
john/feature/add-reactjs-components-local-scripts
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a script which disables eslint and
react-hot-loader. This is necessary when usingnpm linkwith a local copy ofreactjs-components.Disabling eslint prevents linting the transpiled source, and disabling
react-hot-loaderis necessary due to our use of getters inreactjs-components. Read more about it here: gaearon/react-hot-loader#131