-
Notifications
You must be signed in to change notification settings - Fork 801
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dev version of <AppContainer> used with NODE_ENV=test #396
Comments
Yep, you're right. Really we should never use the dev version of |
calesce
added a commit
to calesce/react-hot-loader
that referenced
this issue
Oct 14, 2016
Prevents cases where NODE_ENV=test imports the development AppContainer and patching code. We can leave the NODE_ENV=production check in for manually opting out. Closes gaearon#396.
calesce
added a commit
that referenced
this issue
Oct 14, 2016
Prevents cases where NODE_ENV=test imports the development AppContainer and patching code. We can leave the NODE_ENV=production check in for manually opting out. Closes #396.
Out in |
Works as advertised now. Thanks for the quick turnaround! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Not sure if this is a misunderstanding/misconfiguration on my part, but while generating code coverage with Istanbul I'm seeing:
It looks to me that with
NODE_ENV=test
we're using the dev version of<AppContainer>
.Should that be something like the following?
The text was updated successfully, but these errors were encountered: