Prevent the Babel plugin from breaking the output of babel-node #374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the tagger code inserted by the babel plugin at the end of every file is an IIFE, which happens to break babel-node when it's loaded. by changing it to a variable declaration (that is still immediately invoked), it works the same way and doesn't break the plugin.
|
Glad it worked out! |
|
@loganfsmyth this looks great! do we want to leave a comment in the code saying why we did this seemingly weird thing (assigning the result of a function that doesn't return anything to a variable we don't otherwise use)? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #359.
The tagger code inserted by the babel plugin at the end of every file is an IIFE, which happens to break
babel-nodeoutput when it's loaded. This happens because the code is added to every line that is evaluated by the REPL, so the lines now end with(function() { return; })(), which makes the REPL outputundefinedfor every line.By changing the IIFE from being wrapped in parens to a variable declaration, the output is no longer
undefinedfor every line.The tests pass and from manual testing it doesn't break anything. @nfcampos want to take a look?
Thanks to @loganfsmyth for the help on the Babel slack!