-
-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port of zertosh/eslint-plugin-flow-vars #36
Conversation
@@ -515,4 +520,61 @@ type FooType = {}; | |||
type foo = {}; | |||
``` | |||
|
|||
## Rules (suppressing) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file is generated from the files in .README. You need to create a file for the rule here .README/rules and then include the file into the main template here .README/README.md. Then you need to run npm run readme
to generate the README.md
document.
I have added https://github.com/gajus/eslint-plugin-flowtype/blob/master/CONTRIBUTING to avoid confusion in the future. |
This is a port of [zertosh/eslint-plugin-flow-vars](https://github.com/zertosh/eslint-plugin-flow-vars) adapted to eslint-plugin-flowtype's coding style. Fixes #35
Done, but the doc generation tool (like the test script) assume a very rigid structure for tests – this works fine for rules that report errors, but not for these rules that suppress them. What do you suggest I do? |
Also, let me know if you want me to squash the commits. |
…ugin-flowtype into zertosh-port-flow-vars
No need. |
Using this pattern enables generation of the documentation.
Using ruleTester.defineRule instead.
@zertosh I have made couple of changes to your PR (https://github.com/zertosh/eslint-plugin-flowtype/pull/1). Please review them. If you are happy with these changes, please merge them into the PR branch and I will merge this PR. If not, raise your suggestions. |
Amend Zertosh PR #36
Thank you! |
I added a deprecation notice to eslint-plugin-flow-vars's README and on npm. |
This is a port of zertosh/eslint-plugin-flow-vars adapted to eslint-plugin-flowtype's coding style.
Fixes #35