fix(no-undefined-types): ensure parsing takes into account template…

… names with defaults
gajus · May 24, 2022 · 374daac · 374daac
1 parent 53e4174
commit 374daac
Show file tree

Hide file tree

Showing 3 changed files with 34 additions and 1 deletion.
diff --git a/README.md b/README.md
@@ -10367,6 +10367,19 @@ const a = 'string';
  */
 const a = new Todo();
 // Settings: {"jsdoc":{"mode":"typescript"}}
+
+/**
+ * @template A, [B=SomeDefault]
+ */
+class Foo {
+  /**
+   * @param {A} baz
+   * @return {B}
+   */
+  bar (baz) {
+  }
+}
+// Settings: {"jsdoc":{"mode":"typescript"}}
 ````
 
 

diff --git a/src/jsdocUtils.js b/src/jsdocUtils.js
@@ -1291,7 +1291,7 @@ const parseClosureTemplateTag = (tag) => {
   return tag.name
     .split(',')
     .map((type) => {
-      return type.trim();
+      return type.trim().replace(/^\[(?<name>.*?)=.*\]$/u, '$<name>');
     });
 };
 

diff --git a/test/rules/assertions/noUndefinedTypes.js b/test/rules/assertions/noUndefinedTypes.js
@@ -1258,5 +1258,25 @@ export default {
         },
       },
     },
+    {
+      code: `
+      /**
+       * @template A, [B=SomeDefault]
+       */
+      class Foo {
+        /**
+         * @param {A} baz
+         * @return {B}
+         */
+        bar (baz) {
+        }
+      }
+      `,
+      settings: {
+        jsdoc: {
+          mode: 'typescript',
+        },
+      },
+    },
   ],
 };