fix(require-description-complete-sentence): regression with heading…

… exempting; fixes #1220
gajus · Jun 7, 2024 · 97bc2a8 · 97bc2a8
1 parent e9e4440
commit 97bc2a8
Showing 1 changed file with 4 additions and 5 deletions.
diff --git a/src/rules/requireDescriptionCompleteSentence.js b/src/rules/requireDescriptionCompleteSentence.js
@@ -112,7 +112,9 @@ const validateDescription = (
     return false;
   }
 
-  const paragraphs = extractParagraphs(description).filter(Boolean);
+  const descriptionNoHeadings = description.replaceAll(/^\s*#[^\n]*(\n|$)/gm, '');
+
+  const paragraphs = extractParagraphs(descriptionNoHeadings).filter(Boolean);
 
   return paragraphs.some((paragraph, parIdx) => {
     const sentences = extractSentences(paragraph, abbreviationsRegex);
@@ -192,10 +194,7 @@ const validateDescription = (
 
     const paragraphNoAbbreviations = paragraph.replace(abbreviationsRegex, '');
 
-    if (
-      !/(?:[.?!|]|```)\s*$/u.test(paragraphNoAbbreviations) &&
-      !paragraphNoAbbreviations.startsWith('#')
-    ) {
+    if (!/(?:[.?!|]|```)\s*$/u.test(paragraphNoAbbreviations)) {
       report('Sentences must end with a period.', fix, tag);
       return true;
     }